@@ -1,3 +1,7 @@
+0.08
+    - Fix GIN key update (FIXME no coverage in KiokuDB test suite yet)
+    - uses done_testing in test suite
+
 0.07
     - Various documentation fixes
     - ID stream optimization

@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name:               KiokuDB-Backend-DBI
-version:            0.07
+version:            0.08
 abstract:           ~
 author:  []
 license:            unknown
@@ -19,14 +19,14 @@ requires:
     MooseX::Types::Moose:  0
     Search::GIN:          0
     SQL::Abstract:        0
-    Test::More:           0
+    Test::More:           0.88
     Test::TempDir:        0
     Test::use::ok:        0
 no_index:
     directory:
         - t
         - inc
-generated_by:       ExtUtils::MakeMaker version 6.52
+generated_by:       ExtUtils::MakeMaker version 6.55_02
 meta-spec:
     url:      http://module-build.sourceforge.net/META-spec-v1.4.html
     version:  1.4

@@ -22,11 +22,10 @@ WriteMakefile(
         'Data::Stream::Bulk' => 0.07,
 
         'Test::use::ok' => 0,
-        'Test::More' => 0,
+        'Test::More' => '0.88',
         'Test::TempDir' => 0,
 
         'SQL::Abstract' => 0,
         'Search::GIN' => 0,
     },
 );
-

@@ -14,20 +14,20 @@ not run its Makefile.PL or Build.PL.
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
-SHA1 4be57ad8122bb68c9b7225d4db411faf1ed5eee5 Changes
+SHA1 a61467b14ba854273e36e3c522f9503a0a30c529 Changes
 SHA1 7e1922bf61279c822beaaaa66991e6b5923d4114 MANIFEST
 SHA1 190e9058eb9c6446a1a3f3ddf15b082f1ecde152 MANIFEST.SKIP
-SHA1 dd3e872be992a7e7986e1da7b9af09663fc3d88e META.yml
-SHA1 3f5894a0e7c092809cb98b84e94a4dd9c85a738f Makefile.PL
-SHA1 7e5cdf486aec7b5c7e349e8f693ea2aca45a46c2 lib/KiokuDB/Backend/DBI.pm
+SHA1 da711020f4a32d620124bd654a45c1842246e4c0 META.yml
+SHA1 d558350d7fa4c42ebd93de1be6d15e00dad0e2a5 Makefile.PL
+SHA1 27c535abf8a37d2b4fee5757333479856d8e4e48 lib/KiokuDB/Backend/DBI.pm
 SHA1 cbf9c4e7930c65e3173cf3fbe9d9e3a325a070f5 lib/KiokuDB/Backend/DBI/Schema.pm
-SHA1 4c8e02357d85cd5682ddec469e5d3b93e4bfd1b4 t/01load.t
-SHA1 865122c64f5b0ba70fb1ef46d0932049a6a2c3bd t/basic.t
-SHA1 58c0a6c78f2e7cf6c12ecfc76b51c85024c46af8 t/fixtures.t
+SHA1 5b59d940cc0e259e5f9723fe09f0a2a52ab71558 t/01load.t
+SHA1 a6acddeffcb58d30ea39cbf3db7c022ea5d11fa8 t/basic.t
+SHA1 9a7f20085627339efdaea417a527cc8142c10aff t/fixtures.t
 -----BEGIN PGP SIGNATURE-----
-Version: GnuPG v1.4.7 (Darwin)
+Version: GnuPG/MacGPG2 v2.0.12 (Darwin)
 
-iD8DBQFKcQRjVCwRwOvSdBgRAiHvAJ9X/NxFEHpswM/EYf2KbjoC2/rkqQCgj7Rk
-i2d2qK0rHy6E+rkPaAZ1uAs=
-=T9Ok
+iEYEARECAAYFAksP6+YACgkQVCwRwOvSdBjxJgCePvmsqDYJmVwbFdDZwgoHIOY9
+YoMAoLDWESWdI2iUdRZ/ryzjJHyWhxzz
+=W377
 -----END PGP SIGNATURE-----

@@ -15,7 +15,7 @@ use SQL::Abstract;
 
 use namespace::clean -except => 'meta';
 
-our $VERSION = "0.07";
+our $VERSION = "0.08";
 
 with qw(
     KiokuDB::Backend
@@ -269,16 +269,12 @@ sub insert_rows {
         my ( $storage, $dbh ) = @_;
 
         if ( $self->extract ) {
-            foreach my $rows ( $insert, $update ) {
-                if ( my @ids = @{ $rows->{ids} || [] } ) {
-                    my $bind = join(', ', map { '?' } @ids);
+            if ( my @ids = map { @{ $_->{id} || [] } } $insert, $update ) {
+                my $del_gin_sth = $dbh->prepare_cached("DELETE FROM gin_index WHERE id IN (" . join(", ", ('?') x @ids) . ")");
 
-                    my $del_gin_sth = $dbh->prepare_cached("DELETE FROM gin_index WHERE id = ($bind)");
+                $del_gin_sth->execute(@ids);
 
-                    $del_gin_sth->execute(@ids);
-
-                    $del_gin_sth->finish;
-                }
+                $del_gin_sth->finish;
             }
         }
 

@@ -3,7 +3,6 @@
 use strict;
 use warnings;
 
-use Test::More 'no_plan';
+use Test::More tests => 1;
 
 use ok 'KiokuDB::Backend::DBI';
-

@@ -7,7 +7,6 @@ use Test::More;
 
 BEGIN {
     plan skip_all => "DBD::SQLite  are required" unless eval { require DBI; require DBD::SQLite };
-    plan 'no_plan';
 }
 
 use Test::TempDir;
@@ -58,3 +57,5 @@ SKIP: {
 
     is_deeply( $loaded_entry, $entry, "but eq deeply" );
 }
+
+done_testing;

@@ -4,7 +4,6 @@ use Test::More;
 
 BEGIN {
     plan skip_all => "DBD::SQLite and SQL::Translator are required" unless eval { require DBI; require DBD::SQLite; require SQL::Translator };
-    plan 'no_plan';
 }
 
 use Test::TempDir;
@@ -59,3 +58,5 @@ foreach my $dsn (
         }
     }
 }
+
+done_testing;