@@ -1,25 +1,19 @@
-#######################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-########################################################################
-
use 5.006001;
use strict;
use warnings;
+use Module::Build 0.4200;
+# meta_merge->resources->license now takes an arrayref of URLs in 0.4200 (or
+# thereabouts, but I can't tell for sure from the Changes file).
+
use lib 'inc';
use Perl::Critic::BuildUtilities qw<
required_module_versions
build_required_module_versions
- recommended_module_versions
- test_wrappers_to_generate
- get_PL_files
- dump_unlisted_or_optional_module_versions
emit_tar_warning_if_necessary
+ get_PL_files
>;
use Perl::Critic::Module::Build;
@@ -39,12 +33,11 @@ my $builder = Perl::Critic::Module::Build->new(
requires => { required_module_versions() },
build_requires => { build_required_module_versions() },
- recommends => { recommended_module_versions() },
# Don't require a developer version of Module::Build, even if the
# distribution tarball was created with one. (Oops.)
configure_requires => {
- 'Module::Build' => '0.34',
+ 'Module::Build' => '0.4024',
},
PL_files => get_PL_files(),
@@ -55,7 +48,7 @@ my $builder = Perl::Critic::Module::Build->new(
resources => {
bugtracker => 'https://github.com/Perl-Critic/Perl-Critic/issues',
homepage => 'http://perlcritic.com',
- license => 'http://dev.perl.org/licenses',
+ license => [ 'http://dev.perl.org/licenses' ],
MailingList => 'http://perlcritic.tigris.org/servlets/SummarizeList?listName=users',
repository => 'git://github.com/Perl-Critic/Perl-Critic.git',
},
@@ -74,6 +67,7 @@ my $builder = Perl::Critic::Module::Build->new(
>
],
},
+ x_authority => 'cpan:CRITICRE',
},
add_to_cleanup => [
@@ -88,14 +82,11 @@ my $builder = Perl::Critic::Module::Build->new(
README
>,
values %{ get_PL_files() },
- test_wrappers_to_generate(),
],
);
$builder->create_build_script();
-dump_unlisted_or_optional_module_versions();
-
##############################################################################
# Local Variables:
@@ -1,5 +1,31 @@
Revision history for Perl module Perl::Critic
+1.122 2014-08-25
+
+ [Dependencies]
+ * Now requires PPI-1.218 which has numerous enahncements and bug fixes.
+ Also now requires Readonly-2.00, which obviates the need for Readonly::XS
+ to get fast constants.
+
+ * File::HomeDir, File::Which, and Term::ANSIColor are all required now
+ instead of being optional or recommended. This simplifies our test code
+ and ensures consistent optimal behavior for all users.
+
+ [New Policies]
+ * Added two new policies: BuiltinFunctions::ProhibitUselessTopic and
+ RegularExpressions::ProhibitUselessTopic.
+
+ [Miscellanea]
+ * Updated the perlcritic.el script to use modern Emacs hooks.
+ Thanks to @intrigeri and the Debian team for the patch. Fixes GH #556.
+
+ * Removed all the internal RCS keyword boilerplate blocks that were never
+ getting expanded.
+
+1.121_01 2013-11-17
+
+ * Changes summarized above under 1.122
+
1.121 2013-11-02
[New Features]
@@ -7,11 +33,11 @@ Revision history for Perl module Perl::Critic
[Administrative Changes]
* The source code repository for Perl-Critic has been moved to GitHub
- at http://github.com/Perl-Critc/Perl-Critic. All ticekts from the
+ at http://github.com/Perl-Critic/Perl-Critic. All tickets from the
RT queue have also been moved there. Please use GitHub for submitting
any new bugs or corresponding about existing ones. Huge thanks to
Tim Bunce, Andreas Marienborg, fREW Schmidt, and Graham Knop for
- making this happen.
+ making this happen.
[Miscellanea]
* This change log was reformatted to comply with CPAN::Changes::Spec,
@@ -27,7 +53,7 @@ Revision history for Perl module Perl::Critic
1.120 2013-10-25
[Bug Fixes]
- * Corrected "Possible precedence issue with control flow operator"
+ * Corrected "Possible precedence issue with control flow operator"
warning. This fixes RT #88866
@@ -35,7 +61,7 @@ Revision history for Perl module Perl::Critic
[Bug Fixes]
* Tests were failing with Config::Tiny 2.17 or later, due to a
- change in the error messages produced by that module.
+ change in the error messages produced by that module.
This fixes #16 on Github, #88679 & #88889 on RT.
[Policy Changes]
@@ -46,7 +72,7 @@ Revision history for Perl module Perl::Critic
are now allowed. RT #79138
[Other Changes]
- * Modernized our usage of Exporter. See RT #75300. Thanks
+ * Modernized our usage of Exporter. See RT #75300. Thanks
to Olivier Mengué for the patch.
@@ -71,7 +97,7 @@ Revision history for Perl module Perl::Critic
[New Policies]
* Variables::ProhibitAugmentedAssignmentInDeclaration reports
- constructs like 'my $x += 1'. Contributed by Mike O'Regan
+ constructs like 'my $x += 1'. Contributed by Mike O'Regan.
[Policy Changes]
* BuiltinFunctions::ProhibitLvalueSubstr: Add explicit 'use version'.
@@ -84,7 +110,7 @@ Revision history for Perl module Perl::Critic
'//=', '<<=', and '>>=' are assignment operators. RT #70901.
* ErrorHandling::RequireCheckingReturnValueOfEval now allows things
like grep { eval $_ }. RT #69489.
- * Modules::RequireExplicitPackage now has configuraion option
+ * Modules::RequireExplicitPackage now has configuration option
allow_import_of, to allow the import of specified modules before
the package statement. RT #72660.
* RegularExpressions::ProhibitEnumeratedClasses no longer thinks
@@ -367,7 +393,7 @@ Revision history for Perl module Perl::Critic
(credit Tom Wyant).
* t/20_policy_pod_spelling.t now works (or at least no longer fails)
in non-English locales (again). RT #43291 and RT #48986.
- * Perldoc hae broken link for McCabe score definition. RT #53219
+ * Perldoc has broken link for McCabe score definition. RT #53219
* RT #33935 and #49679 were fixed by upgrading to PPI 1.208
[Other Changes]
@@ -456,7 +482,7 @@ Revision history for Perl module Perl::Critic
useful if you've written a complex command-line or modified your
.perlcriticrc file and you want to see which Policies *would*
be used with the current configuration, if you were actually going
- to critque a file with it.
+ to critique a file with it.
* Perl::Critic::Violation now takes #line directives into account in the
%F, %f, and %l formats. You can get the old values via the new %G, %g,
and %L formats.
@@ -489,7 +515,7 @@ Revision history for Perl module Perl::Critic
* ValuesAndExpressions::RequireInterpolationOfMetachars now allows sigils
in the arguments to "use vars". Contributed by Kevin Ryde, RT #47318.
* ValuesAndExpressions::RequireInterpolationOfMetachars now properly
- ignores email addesses, if you have Email::Address installed. Inspired
+ ignores email addresses, if you have Email::Address installed. Inspired
by the Kevin Ryde contribution in RT #47318.
* Variables::ProhibitPunctuationVars gained the ability to look inside
interpolated strings. Doing this correctly is challenging and things
@@ -515,7 +541,7 @@ Revision history for Perl module Perl::Critic
[Build Fixes]
* There wasn't a specific version given for the List::MoreUtils dependency
- and we're using features that weren't avialable until 0.19. So, we now
+ and we're using features that weren't available until 0.19. So, we now
require version 0.19. Noticed by John J. Trammell, RT #48917.
* Some tests were tied to the specific "true" and "false" values that some
functions were returning. Reported by Michael Schwern, RT #43910.
@@ -638,7 +664,7 @@ Revision history for Perl module Perl::Critic
multiple lines.
* Subroutines::ProtectPrivateSubs no longer regards the exportable POSIX
subroutines whose names begin with underscore as private. RT #38678.
- * Subroutines::RequireArgUnpacking mishandled a complicated sitation with
+ * Subroutines::RequireArgUnpacking mishandled a complicated situation with
$_ being an array reference. RT #39601.
* Variables::RequireLocalizedPunctuationVars now applies to subscripted
names. RT #29384.
@@ -1896,7 +1922,7 @@ Revision history for Perl module Perl::Critic
I also suggest removing your current Perl::Critic installation
before installing this one.
* Improved error message when Perl::Critic dies because PPI can't
- parsee the input code.
+ parse the input code.
* Changed output of -help to be more terse.
* Added -Policy option to perlcritic. The idea is to provide a
compact interface for selecting Policy modules at the command-line.
@@ -18,11 +18,3 @@ INSTALLATION
./Build
./Build test
./Build install
-
-
-#######################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-########################################################################
@@ -50,6 +50,7 @@ lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm
lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringySplit.pm
lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalCan.pm
lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalIsa.pm
+lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUselessTopic.pm
lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidGrep.pm
lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidMap.pm
lib/Perl/Critic/Policy/BuiltinFunctions/RequireBlockGrep.pm
@@ -124,6 +125,7 @@ lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
+lib/Perl/Critic/Policy/RegularExpressions/ProhibitUselessTopic.pm
lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
lib/Perl/Critic/Policy/RegularExpressions/RequireDotMatchAnything.pm
lib/Perl/Critic/Policy/RegularExpressions/RequireExtendedFormatting.pm
@@ -212,6 +214,10 @@ lib/Test/Perl/Critic/Policy.pm
LICENSE
Makefile.PL
MANIFEST This list of files
+META.json
+META.yml
+README
+README.md
t/00_modules.t
t/01_bad_perlcriticrc
t/01_config.t
@@ -265,6 +271,7 @@ t/BuiltinFunctions/ProhibitStringyEval.run
t/BuiltinFunctions/ProhibitStringySplit.run
t/BuiltinFunctions/ProhibitUniversalCan.run
t/BuiltinFunctions/ProhibitUniversalIsa.run
+t/BuiltinFunctions/ProhibitUselessTopic.run
t/BuiltinFunctions/ProhibitVoidGrep.run
t/BuiltinFunctions/ProhibitVoidMap.run
t/BuiltinFunctions/RequireBlockGrep.run
@@ -335,6 +342,7 @@ t/RegularExpressions/ProhibitFixedStringMatches.run
t/RegularExpressions/ProhibitSingleCharAlternation.run
t/RegularExpressions/ProhibitUnusedCapture.run
t/RegularExpressions/ProhibitUnusualDelimiters.run
+t/RegularExpressions/ProhibitUselessTopic.run
t/RegularExpressions/RequireBracesForMultiline.run
t/RegularExpressions/RequireDotMatchAnything.run
t/RegularExpressions/RequireExtendedFormatting.run
@@ -411,13 +419,8 @@ xt/author/43_criticize-run-files.t
xt/author/43_perlcriticrc-run-files
xt/author/80_policysummary.t
xt/author/81_ppi_problems.t
-xt/author/82_optional_modules.t
xt/author/93_version.t
xt/author/94_includes.t
xt/author/95_kwalitee.t
xt/author/98_pod_syntax.t
xt/author/99_pod_coverage.t
-xt/author/generate_without_optional_dependencies_wrappers.PL
-README
-META.yml
-META.json
@@ -4,7 +4,7 @@
"Jeffrey Thalhammer <jeff@imaginative-software.com>"
],
"dynamic_config" : 1,
- "generated_by" : "Module::Build version 0.4007, CPAN::Meta::Converter version 2.132830",
+ "generated_by" : "Module::Build version 0.4203",
"license" : [
"perl_5"
],
@@ -34,16 +34,10 @@
},
"configure" : {
"requires" : {
- "Module::Build" : "0.34"
+ "Module::Build" : "0.4024"
}
},
"runtime" : {
- "recommends" : {
- "File::HomeDir" : "0",
- "File::Which" : "0",
- "Readonly::XS" : "0",
- "Term::ANSIColor" : "2.02"
- },
"requires" : {
"B::Keywords" : "1.05",
"Carp" : "0",
@@ -54,22 +48,24 @@
"Exporter" : "5.63",
"File::Basename" : "0",
"File::Find" : "0",
+ "File::HomeDir" : "0",
"File::Path" : "0",
"File::Spec" : "0",
"File::Spec::Unix" : "0",
"File::Temp" : "0",
+ "File::Which" : "0",
"Getopt::Long" : "0",
"IO::String" : "0",
"IPC::Open2" : "1",
"List::MoreUtils" : "0.19",
"List::Util" : "0",
"Module::Pluggable" : "3.1",
- "PPI" : "1.215",
- "PPI::Document" : "1.215",
- "PPI::Document::File" : "1.215",
- "PPI::Node" : "1.215",
- "PPI::Token::Quote::Single" : "1.215",
- "PPI::Token::Whitespace" : "1.215",
+ "PPI" : "1.218",
+ "PPI::Document" : "1.218",
+ "PPI::Document::File" : "1.218",
+ "PPI::Node" : "1.218",
+ "PPI::Token::Quote::Single" : "1.218",
+ "PPI::Token::Whitespace" : "1.218",
"PPIx::Regexp" : "0.027",
"PPIx::Utilities::Node" : "1.001",
"PPIx::Utilities::Statement" : "1.001",
@@ -79,10 +75,11 @@
"Pod::Select" : "0",
"Pod::Spell" : "1",
"Pod::Usage" : "0",
- "Readonly" : "1.03",
+ "Readonly" : "2",
"Scalar::Util" : "0",
"String::Format" : "1.13",
"Task::Weaken" : "0",
+ "Term::ANSIColor" : "2.02",
"Test::Builder" : "0.92",
"Text::ParseWords" : "3",
"base" : "0",
@@ -97,771 +94,779 @@
"provides" : {
"Perl::Critic" : {
"file" : "lib/Perl/Critic.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Annotation" : {
"file" : "lib/Perl/Critic/Annotation.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Command" : {
"file" : "lib/Perl/Critic/Command.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Config" : {
"file" : "lib/Perl/Critic/Config.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Document" : {
"file" : "lib/Perl/Critic/Document.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception" : {
"file" : "lib/Perl/Critic/Exception.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::AggregateConfiguration" : {
"file" : "lib/Perl/Critic/Exception/AggregateConfiguration.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration" : {
"file" : "lib/Perl/Critic/Exception/Configuration.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Generic" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Generic.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::NonExistentPolicy" : {
"file" : "lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Global" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Global.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Global::ExtraParameter" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Global/ExtraParameter.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Global::ParameterValue" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Global/ParameterValue.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Policy" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Policy.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Policy::ExtraParameter" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Policy/ExtraParameter.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Configuration::Option::Policy::ParameterValue" : {
"file" : "lib/Perl/Critic/Exception/Configuration/Option/Policy/ParameterValue.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Fatal" : {
"file" : "lib/Perl/Critic/Exception/Fatal.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Fatal::Generic" : {
"file" : "lib/Perl/Critic/Exception/Fatal/Generic.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Fatal::Internal" : {
"file" : "lib/Perl/Critic/Exception/Fatal/Internal.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Fatal::PolicyDefinition" : {
"file" : "lib/Perl/Critic/Exception/Fatal/PolicyDefinition.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::IO" : {
"file" : "lib/Perl/Critic/Exception/IO.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Exception::Parse" : {
"file" : "lib/Perl/Critic/Exception/Parse.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::OptionsProcessor" : {
"file" : "lib/Perl/Critic/OptionsProcessor.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy" : {
"file" : "lib/Perl/Critic/Policy.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitComplexMappings.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitReverseSortBlock.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitSleepViaSelect.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringySplit.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalCan" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalCan.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalIsa.pm",
- "version" : "1.121"
+ "version" : "1.122"
+ },
+ "Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic" : {
+ "file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUselessTopic.pm",
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidGrep.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidMap.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/RequireBlockGrep.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/RequireBlockMap.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock" : {
"file" : "lib/Perl/Critic/Policy/BuiltinFunctions/RequireSimpleSortBlock.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading" : {
"file" : "lib/Perl/Critic/Policy/ClassHierarchies/ProhibitAutoloading.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA" : {
"file" : "lib/Perl/Critic/Policy/ClassHierarchies/ProhibitExplicitISA.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless" : {
"file" : "lib/Perl/Critic/Policy/ClassHierarchies/ProhibitOneArgBless.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::ProhibitHardTabs" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/ProhibitHardTabs.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::ProhibitParensWithBuiltins" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/ProhibitParensWithBuiltins.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/ProhibitQuotedWordLists.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/ProhibitTrailingWhitespace.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/RequireConsistentNewlines.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::RequireTidyCode" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::CodeLayout::RequireTrailingCommas" : {
"file" : "lib/Perl/Critic/Policy/CodeLayout/RequireTrailingCommas.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitCStyleForLoops.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitCascadingIfElse" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitCascadingIfElse.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitDeepNests" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitDeepNests.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitLabelsWithSpecialBlockNames" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitLabelsWithSpecialBlockNames.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitMutatingListFunctions" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitPostfixControls.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitUnlessBlocks.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitUnreachableCode.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks" : {
"file" : "lib/Perl/Critic/Policy/ControlStructures/ProhibitUntilBlocks.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Documentation::PodSpelling" : {
"file" : "lib/Perl/Critic/Policy/Documentation/PodSpelling.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName" : {
"file" : "lib/Perl/Critic/Policy/Documentation/RequirePackageMatchesPodName.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Documentation::RequirePodAtEnd" : {
"file" : "lib/Perl/Critic/Policy/Documentation/RequirePodAtEnd.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText" : {
"file" : "lib/Perl/Critic/Policy/Documentation/RequirePodLinksIncludeText.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Documentation::RequirePodSections" : {
"file" : "lib/Perl/Critic/Policy/Documentation/RequirePodSections.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ErrorHandling::RequireCarping" : {
"file" : "lib/Perl/Critic/Policy/ErrorHandling/RequireCarping.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval" : {
"file" : "lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitBacktickOperators" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitBacktickOperators.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordFileHandles.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitExplicitStdin.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitInteractiveTest.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitJoinedReadline" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitJoinedReadline.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitOneArgSelect.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitReadlineInForLoop.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/ProhibitTwoArgOpen.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireBracedFileHandleWithPrint" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireBracedFileHandleWithPrint.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireBriefOpen" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireBriefOpen.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireCheckedClose" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireCheckedClose.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireCheckedOpen" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireCheckedOpen.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireCheckedSyscalls.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::InputOutput::RequireEncodingWithUTF8Layer" : {
"file" : "lib/Perl/Critic/Policy/InputOutput/RequireEncodingWithUTF8Layer.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Miscellanea::ProhibitFormats" : {
"file" : "lib/Perl/Critic/Policy/Miscellanea/ProhibitFormats.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Miscellanea::ProhibitTies" : {
"file" : "lib/Perl/Critic/Policy/Miscellanea/ProhibitTies.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Miscellanea::ProhibitUnrestrictedNoCritic" : {
"file" : "lib/Perl/Critic/Policy/Miscellanea/ProhibitUnrestrictedNoCritic.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Miscellanea::ProhibitUselessNoCritic" : {
"file" : "lib/Perl/Critic/Policy/Miscellanea/ProhibitUselessNoCritic.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::ProhibitAutomaticExportation" : {
"file" : "lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements" : {
"file" : "lib/Perl/Critic/Policy/Modules/ProhibitConditionalUseStatements.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::ProhibitEvilModules" : {
"file" : "lib/Perl/Critic/Policy/Modules/ProhibitEvilModules.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::ProhibitExcessMainComplexity" : {
"file" : "lib/Perl/Critic/Policy/Modules/ProhibitExcessMainComplexity.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::ProhibitMultiplePackages" : {
"file" : "lib/Perl/Critic/Policy/Modules/ProhibitMultiplePackages.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireBarewordIncludes" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireEndWithOne" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireEndWithOne.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireExplicitPackage" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireExplicitPackage.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireFilenameMatchesPackage.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireNoMatchVarsWithUseEnglish" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireNoMatchVarsWithUseEnglish.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Modules::RequireVersionVar" : {
"file" : "lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::NamingConventions::Capitalization" : {
"file" : "lib/Perl/Critic/Policy/NamingConventions/Capitalization.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames" : {
"file" : "lib/Perl/Critic/Policy/NamingConventions/ProhibitAmbiguousNames.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Objects::ProhibitIndirectSyntax" : {
"file" : "lib/Perl/Critic/Policy/Objects/ProhibitIndirectSyntax.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::References::ProhibitDoubleSigils" : {
"file" : "lib/Perl/Critic/Policy/References/ProhibitDoubleSigils.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitComplexRegexes" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitEnumeratedClasses" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitEnumeratedClasses.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitEscapedMetacharacters.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm",
- "version" : "1.121"
+ "version" : "1.122"
+ },
+ "Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic" : {
+ "file" : "lib/Perl/Critic/Policy/RegularExpressions/ProhibitUselessTopic.pm",
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::RequireDotMatchAnything" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/RequireDotMatchAnything.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/RequireExtendedFormatting.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::RegularExpressions::RequireLineBoundaryMatching" : {
"file" : "lib/Perl/Critic/Policy/RegularExpressions/RequireLineBoundaryMatching.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitAmpersandSigils.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitBuiltinHomonyms" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitBuiltinHomonyms.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitExcessComplexity" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitExcessComplexity.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitExplicitReturnUndef.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitManyArgs" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitManyArgs.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitNestedSubs" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitNestedSubs.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitReturnSort" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitReturnSort.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitSubroutinePrototypes" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitSubroutinePrototypes.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProhibitUnusedPrivateSubroutines.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::ProtectPrivateSubs" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/ProtectPrivateSubs.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::RequireArgUnpacking" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/RequireArgUnpacking.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Subroutines::RequireFinalReturn" : {
"file" : "lib/Perl/Critic/Policy/Subroutines/RequireFinalReturn.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitNoStrict.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::ProhibitNoWarnings" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitNoWarnings.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::ProhibitProlongedStrictureOverride" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitProlongedStrictureOverride.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::RequireTestLabels" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/RequireTestLabels.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::TestingAndDebugging::RequireUseWarnings" : {
"file" : "lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseWarnings.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitCommaSeparatedStatements.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitComplexVersion.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitConstantPragma.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEscapedCharacters.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitImplicitNewlines.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitInterpolationOfLiterals.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitLeadingZeros.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitLongChainsOfMethodCalls" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitLongChainsOfMethodCalls.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMagicNumbers.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitMismatchedOperators" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMismatchedOperators.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMixedBooleanOperators.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitNoisyQuotes" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitNoisyQuotes.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitQuotesAsQuotelikeOperatorDelimiters.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitSpecialLiteralHeredocTerminator.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::ProhibitVersionStrings" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitVersionStrings.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::RequireConstantVersion" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/RequireConstantVersion.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::RequireNumberSeparators" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/RequireNumberSeparators.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/RequireQuotedHeredocTerminator.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator" : {
"file" : "lib/Perl/Critic/Policy/ValuesAndExpressions/RequireUpperCaseHeredocTerminator.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitAugmentedAssignmentInDeclaration" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitAugmentedAssignmentInDeclaration.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitConditionalDeclarations.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitEvilVariables" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitEvilVariables.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitLocalVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitLocalVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitMatchVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitMatchVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitPackageVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitPackageVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitPerl4PackageNames" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitPerl4PackageNames.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitPunctuationVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitReusedNames" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitReusedNames.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProhibitUnusedVariables" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProhibitUnusedVariables.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::ProtectPrivateVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/ProtectPrivateVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::RequireInitializationForLocalVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/RequireInitializationForLocalVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::RequireLexicalLoopIterators" : {
"file" : "lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars" : {
"file" : "lib/Perl/Critic/Policy/Variables/RequireLocalizedPunctuationVars.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Policy::Variables::RequireNegativeIndices" : {
"file" : "lib/Perl/Critic/Policy/Variables/RequireNegativeIndices.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyConfig" : {
"file" : "lib/Perl/Critic/PolicyConfig.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyFactory" : {
"file" : "lib/Perl/Critic/PolicyFactory.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyListing" : {
"file" : "lib/Perl/Critic/PolicyListing.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter" : {
"file" : "lib/Perl/Critic/PolicyParameter.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior::Boolean" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior/Boolean.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior::Enumeration" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior/Enumeration.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior::Integer" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior/Integer.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior::String" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior/String.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::PolicyParameter::Behavior::StringList" : {
"file" : "lib/Perl/Critic/PolicyParameter/Behavior/StringList.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::ProfilePrototype" : {
"file" : "lib/Perl/Critic/ProfilePrototype.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Statistics" : {
"file" : "lib/Perl/Critic/Statistics.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::TestUtils" : {
"file" : "lib/Perl/Critic/TestUtils.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Theme" : {
"file" : "lib/Perl/Critic/Theme.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::ThemeListing" : {
"file" : "lib/Perl/Critic/ThemeListing.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::UserProfile" : {
"file" : "lib/Perl/Critic/UserProfile.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils" : {
"file" : "lib/Perl/Critic/Utils.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::Constants" : {
"file" : "lib/Perl/Critic/Utils/Constants.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::DataConversion" : {
"file" : "lib/Perl/Critic/Utils/DataConversion.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::McCabe" : {
"file" : "lib/Perl/Critic/Utils/McCabe.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::POD" : {
"file" : "lib/Perl/Critic/Utils/POD.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::POD::ParseInteriorSequence" : {
"file" : "lib/Perl/Critic/Utils/POD/ParseInteriorSequence.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::PPI" : {
"file" : "lib/Perl/Critic/Utils/PPI.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Utils::Perl" : {
"file" : "lib/Perl/Critic/Utils/Perl.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Perl::Critic::Violation" : {
"file" : "lib/Perl/Critic/Violation.pm",
- "version" : "1.121"
+ "version" : "1.122"
},
"Test::Perl::Critic::Policy" : {
"file" : "lib/Test/Perl/Critic/Policy.pm",
- "version" : "1.121"
+ "version" : "1.122"
}
},
"release_status" : "stable",
@@ -876,7 +881,7 @@
"repository" : {
"url" : "git://github.com/Perl-Critic/Perl-Critic.git"
},
- "x_MailingList" : "http://perlcritic.tigris.org/servlets/SummarizeList?listName=users"
+ "x_mailingList" : "http://perlcritic.tigris.org/servlets/SummarizeList?listName=users"
},
- "version" : "1.121"
+ "version" : "1.122"
}
@@ -3,17 +3,17 @@ abstract: 'Critique Perl source code for best-practices.'
author:
- 'Jeffrey Thalhammer <jeff@imaginative-software.com>'
build_requires:
- Test::Deep: 0
- Test::More: 0
- lib: 0
+ Test::Deep: '0'
+ Test::More: '0'
+ lib: '0'
configure_requires:
- Module::Build: 0.34
+ Module::Build: '0.4024'
dynamic_config: 1
-generated_by: 'Module::Build version 0.4007, CPAN::Meta::Converter version 2.132830'
+generated_by: 'Module::Build version 0.4203, CPAN::Meta::Converter version 2.133380'
license: perl
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
- version: 1.4
+ version: '1.4'
name: Perl-Critic
no_index:
directory:
@@ -26,636 +26,640 @@ no_index:
provides:
Perl::Critic:
file: lib/Perl/Critic.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Annotation:
file: lib/Perl/Critic/Annotation.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Command:
file: lib/Perl/Critic/Command.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Config:
file: lib/Perl/Critic/Config.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Document:
file: lib/Perl/Critic/Document.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception:
file: lib/Perl/Critic/Exception.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::AggregateConfiguration:
file: lib/Perl/Critic/Exception/AggregateConfiguration.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration:
file: lib/Perl/Critic/Exception/Configuration.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Generic:
file: lib/Perl/Critic/Exception/Configuration/Generic.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::NonExistentPolicy:
file: lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option:
file: lib/Perl/Critic/Exception/Configuration/Option.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Global:
file: lib/Perl/Critic/Exception/Configuration/Option/Global.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Global::ExtraParameter:
file: lib/Perl/Critic/Exception/Configuration/Option/Global/ExtraParameter.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Global::ParameterValue:
file: lib/Perl/Critic/Exception/Configuration/Option/Global/ParameterValue.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Policy:
file: lib/Perl/Critic/Exception/Configuration/Option/Policy.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Policy::ExtraParameter:
file: lib/Perl/Critic/Exception/Configuration/Option/Policy/ExtraParameter.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Configuration::Option::Policy::ParameterValue:
file: lib/Perl/Critic/Exception/Configuration/Option/Policy/ParameterValue.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Fatal:
file: lib/Perl/Critic/Exception/Fatal.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Fatal::Generic:
file: lib/Perl/Critic/Exception/Fatal/Generic.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Fatal::Internal:
file: lib/Perl/Critic/Exception/Fatal/Internal.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Fatal::PolicyDefinition:
file: lib/Perl/Critic/Exception/Fatal/PolicyDefinition.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::IO:
file: lib/Perl/Critic/Exception/IO.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Exception::Parse:
file: lib/Perl/Critic/Exception/Parse.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::OptionsProcessor:
file: lib/Perl/Critic/OptionsProcessor.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy:
file: lib/Perl/Critic/Policy.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitComplexMappings.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitReverseSortBlock.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitSleepViaSelect.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringySplit.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalCan:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalCan.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUniversalIsa.pm
- version: 1.121
+ version: '1.122'
+ Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic:
+ file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUselessTopic.pm
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidGrep.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap:
file: lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidMap.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep:
file: lib/Perl/Critic/Policy/BuiltinFunctions/RequireBlockGrep.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap:
file: lib/Perl/Critic/Policy/BuiltinFunctions/RequireBlockMap.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction:
file: lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock:
file: lib/Perl/Critic/Policy/BuiltinFunctions/RequireSimpleSortBlock.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading:
file: lib/Perl/Critic/Policy/ClassHierarchies/ProhibitAutoloading.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA:
file: lib/Perl/Critic/Policy/ClassHierarchies/ProhibitExplicitISA.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless:
file: lib/Perl/Critic/Policy/ClassHierarchies/ProhibitOneArgBless.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::ProhibitHardTabs:
file: lib/Perl/Critic/Policy/CodeLayout/ProhibitHardTabs.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::ProhibitParensWithBuiltins:
file: lib/Perl/Critic/Policy/CodeLayout/ProhibitParensWithBuiltins.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists:
file: lib/Perl/Critic/Policy/CodeLayout/ProhibitQuotedWordLists.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace:
file: lib/Perl/Critic/Policy/CodeLayout/ProhibitTrailingWhitespace.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines:
file: lib/Perl/Critic/Policy/CodeLayout/RequireConsistentNewlines.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::RequireTidyCode:
file: lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::CodeLayout::RequireTrailingCommas:
file: lib/Perl/Critic/Policy/CodeLayout/RequireTrailingCommas.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitCStyleForLoops.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitCascadingIfElse:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitCascadingIfElse.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitDeepNests:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitDeepNests.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitLabelsWithSpecialBlockNames:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitLabelsWithSpecialBlockNames.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitMutatingListFunctions:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitPostfixControls.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitUnlessBlocks.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitUnreachableCode.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks:
file: lib/Perl/Critic/Policy/ControlStructures/ProhibitUntilBlocks.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Documentation::PodSpelling:
file: lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName:
file: lib/Perl/Critic/Policy/Documentation/RequirePackageMatchesPodName.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Documentation::RequirePodAtEnd:
file: lib/Perl/Critic/Policy/Documentation/RequirePodAtEnd.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText:
file: lib/Perl/Critic/Policy/Documentation/RequirePodLinksIncludeText.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Documentation::RequirePodSections:
file: lib/Perl/Critic/Policy/Documentation/RequirePodSections.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ErrorHandling::RequireCarping:
file: lib/Perl/Critic/Policy/ErrorHandling/RequireCarping.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval:
file: lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitBacktickOperators:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitBacktickOperators.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordFileHandles.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitExplicitStdin.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitInteractiveTest.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitJoinedReadline:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitJoinedReadline.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitOneArgSelect.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitReadlineInForLoop.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen:
file: lib/Perl/Critic/Policy/InputOutput/ProhibitTwoArgOpen.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireBracedFileHandleWithPrint:
file: lib/Perl/Critic/Policy/InputOutput/RequireBracedFileHandleWithPrint.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireBriefOpen:
file: lib/Perl/Critic/Policy/InputOutput/RequireBriefOpen.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireCheckedClose:
file: lib/Perl/Critic/Policy/InputOutput/RequireCheckedClose.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireCheckedOpen:
file: lib/Perl/Critic/Policy/InputOutput/RequireCheckedOpen.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls:
file: lib/Perl/Critic/Policy/InputOutput/RequireCheckedSyscalls.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::InputOutput::RequireEncodingWithUTF8Layer:
file: lib/Perl/Critic/Policy/InputOutput/RequireEncodingWithUTF8Layer.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Miscellanea::ProhibitFormats:
file: lib/Perl/Critic/Policy/Miscellanea/ProhibitFormats.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Miscellanea::ProhibitTies:
file: lib/Perl/Critic/Policy/Miscellanea/ProhibitTies.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Miscellanea::ProhibitUnrestrictedNoCritic:
file: lib/Perl/Critic/Policy/Miscellanea/ProhibitUnrestrictedNoCritic.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Miscellanea::ProhibitUselessNoCritic:
file: lib/Perl/Critic/Policy/Miscellanea/ProhibitUselessNoCritic.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::ProhibitAutomaticExportation:
file: lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements:
file: lib/Perl/Critic/Policy/Modules/ProhibitConditionalUseStatements.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::ProhibitEvilModules:
file: lib/Perl/Critic/Policy/Modules/ProhibitEvilModules.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::ProhibitExcessMainComplexity:
file: lib/Perl/Critic/Policy/Modules/ProhibitExcessMainComplexity.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::ProhibitMultiplePackages:
file: lib/Perl/Critic/Policy/Modules/ProhibitMultiplePackages.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireBarewordIncludes:
file: lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireEndWithOne:
file: lib/Perl/Critic/Policy/Modules/RequireEndWithOne.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireExplicitPackage:
file: lib/Perl/Critic/Policy/Modules/RequireExplicitPackage.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage:
file: lib/Perl/Critic/Policy/Modules/RequireFilenameMatchesPackage.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireNoMatchVarsWithUseEnglish:
file: lib/Perl/Critic/Policy/Modules/RequireNoMatchVarsWithUseEnglish.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Modules::RequireVersionVar:
file: lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::NamingConventions::Capitalization:
file: lib/Perl/Critic/Policy/NamingConventions/Capitalization.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames:
file: lib/Perl/Critic/Policy/NamingConventions/ProhibitAmbiguousNames.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Objects::ProhibitIndirectSyntax:
file: lib/Perl/Critic/Policy/Objects/ProhibitIndirectSyntax.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::References::ProhibitDoubleSigils:
file: lib/Perl/Critic/Policy/References/ProhibitDoubleSigils.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitComplexRegexes:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitEnumeratedClasses:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitEnumeratedClasses.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitEscapedMetacharacters.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters:
file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
- version: 1.121
+ version: '1.122'
+ Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic:
+ file: lib/Perl/Critic/Policy/RegularExpressions/ProhibitUselessTopic.pm
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline:
file: lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::RequireDotMatchAnything:
file: lib/Perl/Critic/Policy/RegularExpressions/RequireDotMatchAnything.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting:
file: lib/Perl/Critic/Policy/RegularExpressions/RequireExtendedFormatting.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::RegularExpressions::RequireLineBoundaryMatching:
file: lib/Perl/Critic/Policy/RegularExpressions/RequireLineBoundaryMatching.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitAmpersandSigils.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitBuiltinHomonyms:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitBuiltinHomonyms.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitExcessComplexity:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitExcessComplexity.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitExplicitReturnUndef.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitManyArgs:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitManyArgs.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitNestedSubs:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitNestedSubs.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitReturnSort:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitReturnSort.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitSubroutinePrototypes:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitSubroutinePrototypes.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines:
file: lib/Perl/Critic/Policy/Subroutines/ProhibitUnusedPrivateSubroutines.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::ProtectPrivateSubs:
file: lib/Perl/Critic/Policy/Subroutines/ProtectPrivateSubs.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::RequireArgUnpacking:
file: lib/Perl/Critic/Policy/Subroutines/RequireArgUnpacking.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Subroutines::RequireFinalReturn:
file: lib/Perl/Critic/Policy/Subroutines/RequireFinalReturn.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict:
file: lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitNoStrict.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::ProhibitNoWarnings:
file: lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitNoWarnings.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::ProhibitProlongedStrictureOverride:
file: lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitProlongedStrictureOverride.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::RequireTestLabels:
file: lib/Perl/Critic/Policy/TestingAndDebugging/RequireTestLabels.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict:
file: lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::TestingAndDebugging::RequireUseWarnings:
file: lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseWarnings.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitCommaSeparatedStatements.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitComplexVersion.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitConstantPragma.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEscapedCharacters.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitImplicitNewlines.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitInterpolationOfLiterals.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitLeadingZeros.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitLongChainsOfMethodCalls:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitLongChainsOfMethodCalls.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMagicNumbers.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitMismatchedOperators:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMismatchedOperators.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMixedBooleanOperators.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitNoisyQuotes:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitNoisyQuotes.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitQuotesAsQuotelikeOperatorDelimiters.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitSpecialLiteralHeredocTerminator.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::ProhibitVersionStrings:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitVersionStrings.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::RequireConstantVersion:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/RequireConstantVersion.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::RequireNumberSeparators:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/RequireNumberSeparators.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/RequireQuotedHeredocTerminator.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator:
file: lib/Perl/Critic/Policy/ValuesAndExpressions/RequireUpperCaseHeredocTerminator.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitAugmentedAssignmentInDeclaration:
file: lib/Perl/Critic/Policy/Variables/ProhibitAugmentedAssignmentInDeclaration.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations:
file: lib/Perl/Critic/Policy/Variables/ProhibitConditionalDeclarations.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitEvilVariables:
file: lib/Perl/Critic/Policy/Variables/ProhibitEvilVariables.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitLocalVars:
file: lib/Perl/Critic/Policy/Variables/ProhibitLocalVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitMatchVars:
file: lib/Perl/Critic/Policy/Variables/ProhibitMatchVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitPackageVars:
file: lib/Perl/Critic/Policy/Variables/ProhibitPackageVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitPerl4PackageNames:
file: lib/Perl/Critic/Policy/Variables/ProhibitPerl4PackageNames.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitPunctuationVars:
file: lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitReusedNames:
file: lib/Perl/Critic/Policy/Variables/ProhibitReusedNames.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProhibitUnusedVariables:
file: lib/Perl/Critic/Policy/Variables/ProhibitUnusedVariables.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::ProtectPrivateVars:
file: lib/Perl/Critic/Policy/Variables/ProtectPrivateVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::RequireInitializationForLocalVars:
file: lib/Perl/Critic/Policy/Variables/RequireInitializationForLocalVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::RequireLexicalLoopIterators:
file: lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars:
file: lib/Perl/Critic/Policy/Variables/RequireLocalizedPunctuationVars.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Policy::Variables::RequireNegativeIndices:
file: lib/Perl/Critic/Policy/Variables/RequireNegativeIndices.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyConfig:
file: lib/Perl/Critic/PolicyConfig.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyFactory:
file: lib/Perl/Critic/PolicyFactory.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyListing:
file: lib/Perl/Critic/PolicyListing.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter:
file: lib/Perl/Critic/PolicyParameter.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior:
file: lib/Perl/Critic/PolicyParameter/Behavior.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior::Boolean:
file: lib/Perl/Critic/PolicyParameter/Behavior/Boolean.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior::Enumeration:
file: lib/Perl/Critic/PolicyParameter/Behavior/Enumeration.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior::Integer:
file: lib/Perl/Critic/PolicyParameter/Behavior/Integer.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior::String:
file: lib/Perl/Critic/PolicyParameter/Behavior/String.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::PolicyParameter::Behavior::StringList:
file: lib/Perl/Critic/PolicyParameter/Behavior/StringList.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::ProfilePrototype:
file: lib/Perl/Critic/ProfilePrototype.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Statistics:
file: lib/Perl/Critic/Statistics.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::TestUtils:
file: lib/Perl/Critic/TestUtils.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Theme:
file: lib/Perl/Critic/Theme.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::ThemeListing:
file: lib/Perl/Critic/ThemeListing.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::UserProfile:
file: lib/Perl/Critic/UserProfile.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils:
file: lib/Perl/Critic/Utils.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::Constants:
file: lib/Perl/Critic/Utils/Constants.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::DataConversion:
file: lib/Perl/Critic/Utils/DataConversion.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::McCabe:
file: lib/Perl/Critic/Utils/McCabe.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::POD:
file: lib/Perl/Critic/Utils/POD.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::POD::ParseInteriorSequence:
file: lib/Perl/Critic/Utils/POD/ParseInteriorSequence.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::PPI:
file: lib/Perl/Critic/Utils/PPI.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Utils::Perl:
file: lib/Perl/Critic/Utils/Perl.pm
- version: 1.121
+ version: '1.122'
Perl::Critic::Violation:
file: lib/Perl/Critic/Violation.pm
- version: 1.121
+ version: '1.122'
Test::Perl::Critic::Policy:
file: lib/Test/Perl/Critic/Policy.pm
- version: 1.121
-recommends:
- File::HomeDir: 0
- File::Which: 0
- Readonly::XS: 0
- Term::ANSIColor: 2.02
+ version: '1.122'
requires:
- B::Keywords: 1.05
- Carp: 0
- Config::Tiny: 2
- Email::Address: 1.889
- English: 0
- Exception::Class: 1.23
- Exporter: 5.63
- File::Basename: 0
- File::Find: 0
- File::Path: 0
- File::Spec: 0
- File::Spec::Unix: 0
- File::Temp: 0
- Getopt::Long: 0
- IO::String: 0
- IPC::Open2: 1
- List::MoreUtils: 0.19
- List::Util: 0
- Module::Pluggable: 3.1
- PPI: 1.215
- PPI::Document: 1.215
- PPI::Document::File: 1.215
- PPI::Node: 1.215
- PPI::Token::Quote::Single: 1.215
- PPI::Token::Whitespace: 1.215
- PPIx::Regexp: 0.027
- PPIx::Utilities::Node: 1.001
- PPIx::Utilities::Statement: 1.001
- Perl::Tidy: 0
- Pod::Parser: 0
- Pod::PlainText: 0
- Pod::Select: 0
- Pod::Spell: 1
- Pod::Usage: 0
- Readonly: 1.03
- Scalar::Util: 0
- String::Format: 1.13
- Task::Weaken: 0
- Test::Builder: 0.92
- Text::ParseWords: 3
- base: 0
- charnames: 0
- overload: 0
- strict: 0
- version: 0.77
- warnings: 0
+ B::Keywords: '1.05'
+ Carp: '0'
+ Config::Tiny: '2'
+ Email::Address: '1.889'
+ English: '0'
+ Exception::Class: '1.23'
+ Exporter: '5.63'
+ File::Basename: '0'
+ File::Find: '0'
+ File::HomeDir: '0'
+ File::Path: '0'
+ File::Spec: '0'
+ File::Spec::Unix: '0'
+ File::Temp: '0'
+ File::Which: '0'
+ Getopt::Long: '0'
+ IO::String: '0'
+ IPC::Open2: '1'
+ List::MoreUtils: '0.19'
+ List::Util: '0'
+ Module::Pluggable: '3.1'
+ PPI: '1.218'
+ PPI::Document: '1.218'
+ PPI::Document::File: '1.218'
+ PPI::Node: '1.218'
+ PPI::Token::Quote::Single: '1.218'
+ PPI::Token::Whitespace: '1.218'
+ PPIx::Regexp: '0.027'
+ PPIx::Utilities::Node: '1.001'
+ PPIx::Utilities::Statement: '1.001'
+ Perl::Tidy: '0'
+ Pod::Parser: '0'
+ Pod::PlainText: '0'
+ Pod::Select: '0'
+ Pod::Spell: '1'
+ Pod::Usage: '0'
+ Readonly: '2'
+ Scalar::Util: '0'
+ String::Format: '1.13'
+ Task::Weaken: '0'
+ Term::ANSIColor: '2.02'
+ Test::Builder: '0.92'
+ Text::ParseWords: '3'
+ base: '0'
+ charnames: '0'
+ overload: '0'
+ strict: '0'
+ version: '0.77'
+ warnings: '0'
resources:
- MailingList: http://perlcritic.tigris.org/servlets/SummarizeList?listName=users
bugtracker: https://github.com/Perl-Critic/Perl-Critic/issues
homepage: http://perlcritic.com
license: http://dev.perl.org/licenses
+ mailingList: http://perlcritic.tigris.org/servlets/SummarizeList?listName=users
repository: git://github.com/Perl-Critic/Perl-Critic.git
-version: 1.121
+version: '1.122'
@@ -1,10 +1,3 @@
-#######################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-########################################################################
-
use 5.006001;
use strict;
@@ -601,10 +601,14 @@ PREREQUISITES
Exception::Class
+ File::HomeDir
+
File::Spec
File::Spec::Unix
+ File::Which
+
IO::String
List::MoreUtils
@@ -633,17 +637,12 @@ PREREQUISITES
Task::Weaken
+ Term::ANSIColor
+
Text::ParseWords
version
- The following modules are optional, but recommended for complete
- functionality:
-
- File::HomeDir
-
- File::Which
-
CONTACTING THE DEVELOPMENT TEAM
You are encouraged to subscribe to the mailing list; send a message to
<mailto:users-subscribe@perlcritic.tigris.org>. See also the archives at
@@ -720,7 +719,7 @@ AUTHOR
Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
COPYRIGHT
- Copyright (c) 2005-2011 Imaginative Software Systems. All rights
+ Copyright (c) 2005-2013 Imaginative Software Systems. All rights
reserved.
This program is free software; you can redistribute it and/or modify it
@@ -0,0 +1,3 @@
+# Perl-Critic
+
+The leading static analyzer for Perl. Configurable, extensible, powerful.
@@ -8,20 +8,11 @@
Perl::Critic::TODO - Things for Perl::Critic developers to do
-=head1 SOURCE
-
- $URL$
- $Date$
- $Author$
- $Revision$
-
-
=head1 SEE ALSO
Perl-Critic-More is a separate distribution for less-widely-accepted
policies. It contains its own TODO.pod.
-
=head1 NEW FEATURES
=over
@@ -1,12 +1,5 @@
#!/usr/bin/perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package main;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Command qw< run >;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
# Begin program. Don't run when loaded as a library
@@ -1,12 +1,5 @@
#!/usr/bin/perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.008001;
use strict;
use warnings;
@@ -1,13 +1,5 @@
#!/usr/bin/perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-
use 5.008001;
use strict;
use warnings;
@@ -1,13 +1,5 @@
;;; perlcritic.el --- minor mode for Perl::Critic integration
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;;; $URL$
-;;; $Date$
-;;; $Author$
-;;; $Revision$
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-
-
;;; Readme
;;
;; This is a minor mode for emacs intended to allow you to
@@ -658,9 +650,8 @@ require that the perl document exist in a file anywhere."
;; Set it.
(> (prefix-numeric-value arg) 0)))
- (make-local-hook 'write-file-hooks)
(if perlcritic-mode
- (add-hook 'write-file-hooks 'perlcritic-write-hook)
+ (add-hook 'write-file-hooks 'perlcritic-write-hook nil "local")
(remove-hook 'write-file-hooks 'perlcritic-write-hook)))
;; Make a nice name for perl critic mode. This string will appear at
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::BuildUtilities;
use 5.006001;
@@ -13,18 +6,15 @@ use warnings;
use English q<-no_match_vars>;
-our $VERSION = '1.116';
+our $VERSION = '1.122';
use Exporter 'import';
our @EXPORT_OK = qw<
required_module_versions
build_required_module_versions
- recommended_module_versions
- test_wrappers_to_generate
- get_PL_files
- dump_unlisted_or_optional_module_versions
emit_tar_warning_if_necessary
+ get_PL_files
>;
@@ -42,22 +32,24 @@ sub required_module_versions {
'Exporter' => 5.63,
'File::Basename' => 0,
'File::Find' => 0,
+ 'File::HomeDir' => 0,
'File::Path' => 0,
'File::Spec' => 0,
'File::Spec::Unix' => 0,
'File::Temp' => 0,
+ 'File::Which' => 0,
'Getopt::Long' => 0,
'IO::String' => 0,
'IPC::Open2' => 1,
'List::MoreUtils' => 0.19,
'List::Util' => 0,
'Module::Pluggable' => 3.1,
- 'PPI' => '1.215', # RT 61301
- 'PPI::Document' => '1.215',
- 'PPI::Document::File' => '1.215',
- 'PPI::Node' => '1.215',
- 'PPI::Token::Quote::Single' => '1.215',
- 'PPI::Token::Whitespace' => '1.215',
+ 'PPI' => '1.218', # https://github.com/adamkennedy/PPI/issues/74
+ 'PPI::Document' => '1.218',
+ 'PPI::Document::File' => '1.218',
+ 'PPI::Node' => '1.218',
+ 'PPI::Token::Quote::Single' => '1.218',
+ 'PPI::Token::Whitespace' => '1.218',
'PPIx::Regexp' => '0.027', # Literal { deprecated in re
'PPIx::Utilities::Node' => '1.001',
'PPIx::Utilities::Statement' => '1.001',
@@ -67,10 +59,11 @@ sub required_module_versions {
'Pod::Select' => 0,
'Pod::Spell' => 1,
'Pod::Usage' => 0,
- 'Readonly' => 1.03,
+ 'Readonly' => 2.00,
'Scalar::Util' => 0,
'String::Format' => 1.13,
'Task::Weaken' => 0,
+ 'Term::ANSIColor' => '2.02',
'Test::Builder' => 0.92,
'Text::ParseWords' => 3,
'base' => 0,
@@ -92,63 +85,6 @@ sub build_required_module_versions {
}
-sub recommended_module_versions {
- return (
- 'File::HomeDir' => 0,
- 'Readonly::XS' => 0,
-
- # If the following changes, the corresponding change needs to be made
- # in $Perl::Critic::Utils::Constants::_MODULE_VERSION_TERM_ANSICOLOR.
- 'Term::ANSIColor' => '2.02',
-
- # All of these are for Documentation::PodSpelling
- 'File::Which' => 0,
- );
-}
-
-
-sub test_wrappers_to_generate {
- my @tests_to_be_wrapped = qw<
- t/00_modules.t
- t/01_config.t
- t/01_config_bad_perlcriticrc.t
- t/01_policy_config.t
- t/02_policy.t
- t/03_pragmas.t
- t/04_options_processor.t
- t/05_utils.t
- t/05_utils_ppi.t
- t/05_utils_pod.t
- t/06_violation.t
- t/07_command.t
- t/07_perlcritic.t
- t/08_document.t
- t/09_theme.t
- t/10_user_profile.t
- t/11_policy_factory.t
- t/12_policy_listing.t
- t/12_theme_listing.t
- t/13_bundled_policies.t
- t/14_policy_parameters.t
- t/15_statistics.t
- t/20_policies.t
- t/20_policy_pod_spelling.t
- t/20_policy_prohibit_evil_modules.t
- t/20_policy_prohibit_hard_tabs.t
- t/20_policy_prohibit_trailing_whitespace.t
- t/20_policy_require_consistent_newlines.t
- t/20_policy_require_tidy_code.t
- xt/author/80_policysummary.t
- t/92_memory_leaks.t
- xt/author/94_includes.t
- >;
-
- return
- map
- { "xt/author/generated/${_}_without_optional_dependencies.t" }
- @tests_to_be_wrapped;
-}
-
my @TARGET_FILES = qw<
t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run
t/NamingConventions/Capitalization.run
@@ -158,45 +94,9 @@ my @TARGET_FILES = qw<
sub get_PL_files {
my %PL_files = map { ( "$_.PL" => $_ ) } @TARGET_FILES;
- $PL_files{'xt/author/generate_without_optional_dependencies_wrappers.PL'} =
- [ test_wrappers_to_generate() ];
-
return \%PL_files;
}
-sub dump_unlisted_or_optional_module_versions {
- print
- "\nVersions of optional/unlisted/indirect dependencies:\n\n";
-
- my @unlisted_modules = (
- qw<
- >,
- keys %{ { recommended_module_versions() } },
- );
-
- foreach my $module (sort @unlisted_modules) {
- my $version;
-
- if ($module eq 'Readonly::XS') {
- eval 'use Readonly; use Readonly::XS; $version = $Readonly::XS::VERSION;';
- }
- else {
- eval "use $module; \$version = \$${module}::VERSION;";
- }
- if ($EVAL_ERROR) {
- $version = 'not installed';
- } elsif (not defined $version) {
- $version = 'undef';
- }
-
- print " $module = $version\n";
- }
-
- print "\n";
-
- return;
-}
-
sub emit_tar_warning_if_necessary {
if ( os_is( qw<Solaris> ) ) {
print <<'END_OF_TAR_WARNING';
@@ -232,18 +132,6 @@ Various utilities used in assembling Perl::Critic, primary for use by
=over
-=item C<recommended_module_versions()>
-
-Returns a hash mapping between recommended (but not required) modules
-for Perl::Critic and the minimum version required of each module,
-
-
-=item C<test_wrappers_to_generate()>
-
-Returns a list of test wrappers to be generated by
-F<xt/author/generate_without_optional_dependencies_wrappers.PL>.
-
-
=item C<get_PL_files()>
Returns a reference to a hash with a mapping from the name of a .PL
@@ -1,10 +1,3 @@
-#######################################################################
-# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/common/inc/Perl/Critic/Module/Build/Standard.pm $
-# $Date: 2011-01-30 14:13:17 -0800 (Sun, 30 Jan 2011) $
-# $Author: clonezone $
-# $Revision: 4016 $
-########################################################################
-
package Perl::Critic::Module::Build::Standard;
use 5.006001;
@@ -1,10 +1,3 @@
-#######################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-########################################################################
-
package Perl::Critic::Module::Build;
use 5.006001;
@@ -77,6 +70,7 @@ sub _run_nytprof {
--theme=core
--exclude=TidyCode
--exclude=PodSpelling
+ --exclude=RcsKeywords
blib
>;
warn "Running: $this_perl @perl_args @perlcritic_args\n";
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicySummaryGenerator;
use 5.006001;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Annotation;
use 5.006001;
@@ -20,7 +13,7 @@ use Readonly;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Scalar my $LAST_ELEMENT => -1;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
=pod
=head1 NAME
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Command;
use 5.006001;
@@ -28,7 +21,7 @@ use Perl::Critic::Violation qw<>;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -208,7 +201,7 @@ sub _get_input {
# Test to make sure all the specified files or directories
# actually exist. If any one of them is bogus, then die.
- if ( my $nonexistent = first { ! -e $_ } @args ) {
+ if ( my $nonexistent = first { ! -e } @args ) {
my $msg = qq{No such file or directory: '$nonexistent'};
pod2usage( -exitstatus => 1, -message => $msg, -verbose => 0);
}
@@ -217,7 +210,7 @@ sub _get_input {
# then we process it as-is (even though it may not actually
# be Perl code). If argument is a directory, recursively
# search the directory for files that look like Perl code.
- return map { -d $_ ? Perl::Critic::Utils::all_perl_files($_) : $_ } @args;
+ return map { (-d) ? Perl::Critic::Utils::all_perl_files($_) : $_ } @args;
}
}
@@ -639,7 +632,7 @@ sub _render_policy_docs {
require Perl::Critic::PolicyFactory;
my @site_policies = Perl::Critic::PolicyFactory->site_policy_names();
- my @matching_policies = grep { $_ =~ m/$pattern/ixms } @site_policies;
+ my @matching_policies = grep { /$pattern/ixms } @site_policies;
# "-T" means don't send to pager
my @perldoc_output = map {`perldoc -T $_`} @matching_policies; ## no critic (ProhibitBacktick)
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Config;
use 5.006001;
@@ -36,7 +29,7 @@ use Perl::Critic::Utils::DataConversion qw< boolean_to_number dor >;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
=pod
=for stopwords lookup RequireBlockGrep
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Document;
use 5.006001;
@@ -29,7 +22,7 @@ use PPIx::Regexp 0.010 qw< >;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -679,7 +672,7 @@ This facade does not implement the overloaded operators from
L<PPI::Document|PPI::Document> (that is, the C<use overload ...>
work). Therefore, users of this facade must not rely on that syntactic
sugar. So, for example, instead of C<my $source = "$doc";> you should
-write C<my $source = $doc->content();>
+write C<< my $source = $doc->content(); >>
Perhaps there is a CPAN module out there which implements a facade
better than we do here?
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::AggregateConfiguration;
use 5.006001;
@@ -17,7 +10,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Generic;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::NonExistentPolicy;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Global::ExtraParameter;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Global::ParameterValue;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,17 +1,10 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Global;
use 5.006001;
use strict;
use warnings;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Policy::ExtraParameter;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Policy::ParameterValue;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option::Policy;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Perl::Critic::Utils qw{ &policy_short_name };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,17 +1,10 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration::Option;
use 5.006001;
use strict;
use warnings;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,17 +1,10 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Configuration;
use 5.006001;
use strict;
use warnings;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Fatal::Generic;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Fatal::Internal;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Fatal::PolicyDefinition;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,17 +1,10 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Fatal;
use 5.006001;
use strict;
use warnings;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::IO;
use 5.006001;
@@ -17,7 +10,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception::Parse;
use 5.006001;
@@ -17,7 +10,7 @@ use Readonly;
use Perl::Critic::Utils qw< :characters >;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,17 +1,10 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Exception;
use 5.006001;
use strict;
use warnings;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::OptionsProcessor;
use 5.006001;
@@ -24,7 +17,7 @@ use Perl::Critic::Utils::Constants qw<
>;
use Perl::Critic::Utils::DataConversion qw< dor >;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr;
use 5.006001;
@@ -16,7 +9,7 @@ use version 0.77 ();
use Perl::Critic::Utils qw{ :severities :classification :language };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval;
use 5.006001;
@@ -18,7 +11,7 @@ use PPI::Document;
use Perl::Critic::Utils qw{ :booleans :severities :classification :ppi $SCOLON };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalCan;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -0,0 +1,207 @@
+package Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic;
+
+use strict;
+use warnings;
+use Readonly;
+
+use Perl::Critic::Utils qw{ :severities :classification :ppi };
+use base 'Perl::Critic::Policy';
+
+our $VERSION = '1.122';
+
+## no critic ( ValuesAndExpressions::RequireInterpolationOfMetachars )
+## The numerous $_ variables make false positives.
+Readonly::Scalar my $DESC => q{Useless use of $_};
+Readonly::Scalar my $EXPL_FILETEST => q{$_ should be omitted when using a filetest operator};
+Readonly::Scalar my $EXPL_FUNCTION => q{$_ should be omitted when calling "%s"};
+Readonly::Scalar my $EXPL_FUNCTION_SPLIT => q{$_ should be omitted when calling "split" with two arguments};
+
+sub supported_parameters { return () }
+sub default_severity { return $SEVERITY_LOW }
+sub default_themes { return qw( core ) }
+sub applies_to { return 'PPI::Token::Operator', 'PPI::Token::Word' }
+
+my @filetest_operators = qw( -r -w -x -o -R -W -X -O -e -z -s -f -d -l -p -S -b -c -u -g -k -T -B -M -A -C );
+my %filetest_operators = map { ($_ => 1) } @filetest_operators;
+
+my @topical_funcs = qw(
+ abs alarm
+ chomp chop chr chroot cos
+ defined
+ eval exp
+ glob
+ hex
+ int
+ lc lcfirst length log lstat
+ mkdir
+ oct ord
+ pos print
+ quotemeta
+ readlink readpipe ref require reverse rmdir
+ sin split sqrt stat study
+ uc ucfirst unlink unpack
+);
+my %topical_funcs = map { ($_ => 1) } @topical_funcs;
+
+sub violates {
+ my ( $self, $elem, undef ) = @_;
+
+ my $content = $elem->content;
+
+ # Are we looking at a filetest?
+ if ( $filetest_operators{ $content } ) {
+ # Is there a $_ following it?
+ my $op_node = $elem->snext_sibling;
+ if ( $op_node && $op_node->isa('PPI::Token::Magic') ) {
+ my $op = $op_node->content;
+ if ( $op eq '$_' ) {
+ return $self->violation( $DESC, $EXPL_FILETEST, $elem );
+ }
+ }
+ return;
+ }
+
+ if ( $topical_funcs{ $content } && is_perl_builtin( $elem ) ) {
+ my $is_split = $content eq 'split';
+
+ my @args = parse_arg_list( $elem );
+
+ my $nth_arg_for_topic;
+ if ( $is_split ) {
+ return if @args != 2; # Ignore split( /\t/ ) or split( /\t/, $_, 3 )
+ $nth_arg_for_topic = 2;
+ }
+ else {
+ $nth_arg_for_topic = 1;
+ }
+
+ if ( @args == $nth_arg_for_topic ) {
+ my $topic_arg = $args[ $nth_arg_for_topic - 1 ];
+ my @tokens = @{$topic_arg};
+ if ( (@tokens == 1) && ($tokens[0]->content eq '$_') ) {
+ my $msg = $is_split ? $EXPL_FUNCTION_SPLIT : (sprintf $EXPL_FUNCTION, $content);
+ return $self->violation( $DESC, $msg, $elem );
+ }
+ }
+ return;
+ }
+
+ return;
+}
+
+
+1;
+
+__END__
+
+=pod
+
+=for stopwords filetest
+
+=head1 NAME
+
+Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic - Don't pass $_ to built-in functions that assume it, or to most filetest operators.
+
+=head1 AFFILIATION
+
+This Policy is part of the L<Perl::Critic|Perl::Critic> distribution.
+
+=head1 DESCRIPTION
+
+There are a number of places where C<$_>, or "the topic" variable,
+is unnecessary.
+
+=head2 Topic unnecessary for certain Perl built-in functions
+
+Many Perl built-in functions will operate on C<$_> if no argument
+is passed. For example, the C<length> function will operate on
+C<$_> by default. This snippet:
+
+ for ( @list ) {
+ if ( length( $_ ) == 4 ) { ...
+
+is more idiomatically written as:
+
+ for ( @list ) {
+ if ( length == 4 ) { ...
+
+In the case of the C<split> function, the second argument is the
+one that defaults to C<$_>. This snippet:
+
+ for ( @list ) {
+ my @args = split /\t/, $_;
+
+is better written as:
+
+ for ( @list ) {
+ my @args = split /\t/;
+
+There is one built-in that this policy does B<not> check for:
+C<reverse> called with C<$_>.
+
+The C<reverse> function only operates on C<$_> if called in scalar
+context. Therefore:
+
+ for ( @list ) {
+ my $backwards = reverse $_;
+
+is better written as:
+
+ for ( @list ) {
+ my $backwards = reverse;
+
+However, the distinction for scalar vs. list context on C<reverse>
+is not yet working. See L<KNOWN BUGS|KNOWN BUGS> below.
+
+=head2 Topic unnecessary for most filetest operators
+
+Another place that C<$_> is unnecessary is with a filetest operator.
+
+ # These are identical.
+ my $size = -s $_;
+ my $size = -s;
+
+ # These are identical.
+ if ( -r $_ ) { ...
+ if ( -r ) { ...
+
+The exception is after the C<-t> filetest operator, which instead of
+defaulting to C<$_> defaults to C<STDIN>.
+
+ # These are NOT identical.
+ if ( -t $_ ) { ...
+ if ( -t ) { ... # Checks STDIN, not $_
+
+=head1 KNOWN BUGS
+
+This policy flags a false positive on C<reverse> called in list
+context, since C<reverse> in list context does I<not> assume C<$_>.
+
+ my $s = reverse( $_ ); # $_ is useless.
+ my @a = reverse( $_ ); # $_ is not useless here.
+
+=head1 CONFIGURATION
+
+This Policy is not configurable except for the standard options.
+
+=head1 AUTHOR
+
+Andy Lester <andy@petdance.com>
+
+=head1 COPYRIGHT
+
+Copyright (c) 2013 Andy Lester <andy@petdance.com>
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the Artistic License 2.0.
+
+=cut
+
+# Local Variables:
+# mode: cperl
+# cperl-indent-level: 4
+# fill-column: 78
+# indent-tabs-mode: nil
+# c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification is_in_void_context };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification is_in_void_context };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep;
# DEVELOPER NOTE: this module is used as an example in DEVELOPER.pod.
@@ -19,7 +12,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -58,14 +51,13 @@ __END__
=head1 NAME
-Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep - Write C<grep { $_ =~ /$pattern/ } @list> instead of C<grep /$pattern/, @list>.
+Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep - Write C<grep { /$pattern/ } @list> instead of C<grep /$pattern/, @list>.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
-
=head1 DESCRIPTION
The expression forms of C<grep> and C<map> are awkward and hard to
@@ -77,13 +69,10 @@ read. Use the block forms instead.
@mapped = map transform($_), @list; #not ok
@mapped = map { transform($_) } @list; #ok
-
-
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
-
=head1 SEE ALSO
L<Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval|Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval>
@@ -96,7 +85,7 @@ Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
=head1 COPYRIGHT
-Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
+Copyright (c) 2005-2013 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -54,15 +47,13 @@ __END__
=head1 NAME
-Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap - Write C<map { $_ =~ /$pattern/ } @list> instead of C<map /$pattern/, @list>.
-
+Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap - Write C<map { /$pattern/ } @list> instead of C<map /$pattern/, @list>.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
-
=head1 DESCRIPTION
The expression forms of C<grep> and C<map> are awkward and hard to
@@ -74,20 +65,16 @@ read. Use the block forms instead.
@mapped = map transform($_), @list; #not ok
@mapped = map { transform($_) } @list; #ok
-
-
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
-
=head1 SEE ALSO
L<Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval|Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval>
L<Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep|Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep>
-
=head1 AUTHOR
Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
@@ -95,7 +82,7 @@ Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
=head1 COPYRIGHT
-Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
+Copyright (c) 2005-2013 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::ProhibitHardTabs;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::ProhibitParensWithBuiltins;
use 5.006001;
@@ -19,7 +12,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities :classification};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw{ :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines;
use 5.006001;
@@ -17,7 +10,7 @@ use PPI::Token::Whitespace;
use English qw(-no_match_vars);
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Scalar my $LINE_END => qr/\015{1,2}\012|[\012\015]/mxs;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::RequireTidyCode;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Tidy qw< >;
use Perl::Critic::Utils qw{ :booleans :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::CodeLayout::RequireTrailingCommas;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitCascadingIfElse;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitDeepNests;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitLabelsWithSpecialBlockNames;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Hash my %SPECIAL_BLOCK_NAMES =>
hashify( qw< BEGIN END INIT CHECK UNITCHECK > );
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitMutatingListFunctions;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw{
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw< :characters :severities :classification hashify >;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities :data_conversion :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :data_conversion :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Array my @TERMINALS => qw( die exit croak confess );
Readonly::Hash my %TERMINALS => hashify( @TERMINALS );
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Documentation::PodSpelling;
use 5.006001;
@@ -31,7 +24,7 @@ use Perl::Critic::Exception::Fatal::Generic qw{ throw_generic };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName;
use 5.006001;
@@ -17,7 +10,7 @@ use English qw{ -no_match_vars };
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Documentation::RequirePodAtEnd;
use 5.006001;
@@ -17,7 +10,7 @@ use List::Util qw(first);
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText;
use 5.006001;
@@ -21,7 +14,7 @@ use Perl::Critic::Utils::POD::ParseInteriorSequence;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Documentation::RequirePodSections;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :characters :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -241,7 +234,7 @@ sub _parse_sections {
my @sections = split m{ \s* [|] \s* }xms, $config_string;
- return map { uc $_ } @sections; # Normalize CaSe!
+ return map { uc } @sections; # Normalize CaSe!
}
sub _parse_lib_sections {
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ErrorHandling::RequireCarping;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Utils qw{
use Perl::Critic::Utils::PPI qw{ is_ppi_expression_or_generic_statement };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval;
use 5.006001;
@@ -19,7 +12,7 @@ use Perl::Critic::Utils qw< :booleans :characters :severities hashify
precedence_of >;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -88,7 +81,7 @@ sub _is_in_right_hand_side_of_assignment {
EQUALS_SCAN:
while ($previous) {
if ( $previous->isa('PPI::Token::Operator') ) {
- return $TRUE if $previous->content() eq q<=>;
+ return $TRUE if $previous->content() =~ m/= \Z/xms;
last EQUALS_SCAN if _is_effectively_a_comma($previous);
}
$previous = $previous->sprevious_sibling();
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitBacktickOperators;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ :severities is_in_void_context };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin;
use 5.006001;
@@ -16,7 +9,7 @@ use List::MoreUtils qw(any);
use Perl::Critic::Utils qw{ :severities :classification &parse_arg_list };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitJoinedReadline;
use 5.006001;
@@ -16,7 +9,7 @@ use List::MoreUtils qw(any);
use Perl::Critic::Utils qw{ :severities :classification parse_arg_list };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop;
use 5.006001;
@@ -17,7 +10,7 @@ use List::Util qw< first >;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen;
use 5.006001;
@@ -18,7 +11,7 @@ use version;
use Perl::Critic::Utils qw{ :severities :classification :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireBracedFileHandleWithPrint;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireBriefOpen;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw{ :severities :classification :booleans
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireCheckedClose;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireCheckedOpen;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{ :booleans :characters :severities :classification
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/Perl-Critic/lib/Perl/Critic/Policy/InputOutput/RequireEncodingWithUTF8Layer.pm $
-# $Date: 2010-06-22 16:14:07 -0400 (Tue, 22 Jun 2010) $
-# $Author: clonezone $
-# $Revision: 3843 $
-##############################################################################
-
package Perl::Critic::Policy::InputOutput::RequireEncodingWithUTF8Layer;
use 5.006001;
@@ -18,7 +11,7 @@ use version;
use Perl::Critic::Utils qw{ :severities :ppi };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Miscellanea::ProhibitFormats;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Miscellanea::ProhibitTies;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Miscellanea::ProhibitUnrestrictedNoCritic;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw<:severities :booleans>;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Miscellanea::ProhibitUselessNoCritic;
use 5.006001;
@@ -18,7 +11,7 @@ use List::MoreUtils qw< none >;
use Perl::Critic::Utils qw{ :severities :classification hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::ProhibitAutomaticExportation;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ :severities };
use List::MoreUtils qw(any);
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,9 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
package Perl::Critic::Policy::Modules::ProhibitEvilModules;
use 5.006001;
@@ -21,7 +15,7 @@ use Perl::Critic::Utils qw{
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::ProhibitExcessMainComplexity;
use 5.006001;
@@ -19,7 +12,7 @@ use base 'Perl::Critic::Policy';
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::ProhibitMultiplePackages;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireBarewordIncludes;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireEndWithOne;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireExplicitPackage;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Utils qw{ :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireNoMatchVarsWithUseEnglish;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw< :characters :severities >;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Modules::RequireVersionVar;
use 5.006001;
@@ -17,7 +10,7 @@ use List::MoreUtils qw(any);
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::NamingConventions::Capitalization;
use 5.006001;
@@ -32,7 +25,7 @@ use PPIx::Utilities::Statement qw<
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Objects::ProhibitIndirectSyntax;
use 5.006001;
@@ -18,7 +11,7 @@ use Readonly;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::References::ProhibitDoubleSigils;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :data_conversion :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitComplexRegexes;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitEnumeratedClasses;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw{ :booleans :severities hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters;
use 5.006001;
@@ -18,7 +11,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches;
use 5.006001;
@@ -19,7 +12,7 @@ use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation;
use 5.006001;
@@ -19,7 +12,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture;
use 5.006001;
@@ -24,7 +17,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -123,9 +116,9 @@ sub _enough_uses_in_regexp {
}, _make_regexp_checker() );
}
- return ( none {not defined $_} @{$captures} )
+ return ( none {not defined} @{$captures} )
&& ( !%{$named_captures} ||
- none {defined $_} values %{$named_captures} );
+ none {defined} values %{$named_captures} );
}
sub _enough_assignments {
@@ -190,7 +183,7 @@ sub _enough_assignments {
}
}
- return none {not defined $_} @{$captures};
+ return none {not defined} @{$captures};
}
sub _symbol_is_slurpy {
@@ -298,9 +291,9 @@ sub _enough_magic {
_check_for_magic($elem, $re, $captures, $named_captures, $doc);
- return ( none {not defined $_} @{$captures} )
+ return ( none {not defined} @{$captures} )
&& ( !%{$named_captures} ||
- none {defined $_} values %{$named_captures} );
+ none {defined} values %{$named_captures} );
}
# void return
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters;
use 5.006001;
@@ -19,7 +12,7 @@ use Perl::Critic::Utils qw{ :booleans :severities hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -0,0 +1,116 @@
+package Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic;
+
+use strict;
+use warnings;
+use Readonly;
+
+use Perl::Critic::Utils qw{ :severities :classification :ppi };
+use base 'Perl::Critic::Policy';
+
+our $VERSION = '1.122';
+
+## no critic ( ValuesAndExpressions::RequireInterpolationOfMetachars )
+## The numerous $_ variables make false positives.
+Readonly::Scalar my $DESC => q{Useless use of $_};
+Readonly::Scalar my $EXPL => q{$_ should be omitted when matching a regular expression};
+
+sub supported_parameters { return () }
+sub default_severity { return $SEVERITY_LOW }
+sub default_themes { return qw( core ) }
+sub applies_to { return 'PPI::Token::Magic' }
+
+sub violates {
+ my ( $self, $elem, undef ) = @_;
+
+ my $content = $elem->content;
+ if ( $content eq q{$_} ) {
+ # Is there an op following the $_ ?
+ my $op_node = $elem->snext_sibling;
+ if ( $op_node && $op_node->isa('PPI::Token::Operator') ) {
+ # If the op is a regex match, then we have an unnecessary $_ .
+ my $op = $op_node->content;
+ if ( $op eq q{=~} || $op eq q{!~} ) {
+ my $target_node = $op_node->snext_sibling;
+ if ( $target_node && ($target_node->isa('PPI::Token::Regexp') || $target_node->isa('PPI::Token::QuoteLike::Regexp')) ) {
+ return $self->violation( $DESC, $EXPL, $elem );
+ }
+ }
+ }
+ }
+
+ return;
+}
+
+1;
+
+__END__
+
+=pod
+
+=head1 NAME
+
+Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic - Don't use $_ to match against regexes.
+
+=head1 AFFILIATION
+
+This Policy is part of the L<Perl::Critic|Perl::Critic> distribution.
+
+=head1 DESCRIPTION
+
+It is not necessary to specify the topic variable C<$_> when matching
+against a regular expression.
+
+Match or substitution operations are performed against variables, such as:
+
+ $x =~ /foo/;
+ $x =~ s/foo/bar/;
+ $x =~ tr/a-mn-z/n-za-m/;
+
+If a variable is not specified, the match is against C<$_>.
+
+ # These are identical.
+ /foo/;
+ $_ =~ /foo/;
+
+ # These are identical.
+ s/foo/bar/;
+ $_ =~ s/foo/bar/;
+
+ # These are identical.
+ tr/a-mn-z/n-za-m/;
+ $_ =~ tr/a-mn-z/n-za-m/;
+
+This applies to negative matching as well.
+
+ # These are identical
+ if ( $_ !~ /DEBUG/ ) { ...
+ if ( !/DEBUG ) { ...
+
+Including the C<$_ =~> or C<$_ !~> is unnecessary, adds complexity,
+and is not idiomatic Perl.
+
+=head1 CONFIGURATION
+
+This Policy is not configurable except for the standard options.
+
+=head1 AUTHOR
+
+Andy Lester <andy@petdance.com>
+
+=head1 COPYRIGHT
+
+Copyright (c) 2013 Andy Lester <andy@petdance.com>
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the Artistic License 2.0.
+
+=cut
+
+# Local Variables:
+# mode: cperl
+# cperl-indent-level: 4
+# fill-column: 78
+# indent-tabs-mode: nil
+# c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline;
use 5.006001;
@@ -19,7 +12,7 @@ use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::RequireDotMatchAnything;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::RegularExpressions::RequireLineBoundaryMatching;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities hashify };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitBuiltinHomonyms;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{ :severities :data_conversion
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitExcessComplexity;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils::McCabe qw{ calculate_mccabe_of_sub };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitManyArgs;
use 5.006001;
@@ -21,7 +14,7 @@ use Carp;
use Perl::Critic::Utils qw{ :booleans :severities split_nodes_on_comma };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitNestedSubs;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitReturnSort;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitSubroutinePrototypes;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines;
use 5.006001;
@@ -21,7 +14,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::ProtectPrivateSubs;
use 5.006001;
@@ -20,7 +13,7 @@ use Perl::Critic::Utils qw<
>;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -36,7 +29,7 @@ sub supported_parameters {
description => 'Pattern that determines what a private subroutine is.',
default_string => '\b_\w+\b', ## no critic (RequireInterpolationOfMetachars)
behavior => 'string',
- parser => \& _parse_private_name_regex,
+ parser => \&_parse_private_name_regex,
},
{
name => 'allow',
@@ -141,7 +134,7 @@ sub violates {
sub _is_other_pkg_private_function {
my ( $self, $elem ) = @_;
- return if ! is_function_call($elem) && ! is_method_call($elem);
+ return if ! is_method_call($elem) && ! is_function_call($elem);
my $private_name_regex = $self->{_private_name_regex};
my $content = $elem->content();
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::RequireArgUnpacking;
use 5.006001;
@@ -20,11 +13,11 @@ use List::Util qw(first);
use List::MoreUtils qw(uniq any);
use Perl::Critic::Utils qw<
- :booleans :characters hashify :severities words_from_string
+ :booleans :characters :classification hashify :severities words_from_string
>;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -151,7 +144,7 @@ sub _is_unpack {
return $TRUE if
$prev
and $prev->isa('PPI::Token::Operator')
- and q{=} eq $prev->content()
+ and is_assignment_operator($prev->content())
and (
not $next
or $next->isa('PPI::Token::Structure')
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Subroutines::RequireFinalReturn;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Exception::Fatal::Internal qw{ throw_internal };
use Perl::Critic::Utils qw{ :characters :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict;
use 5.006001;
@@ -17,7 +10,7 @@ use List::MoreUtils qw(all);
use Perl::Critic::Utils qw{ :characters :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::ProhibitNoWarnings;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Exception::Fatal::Internal qw{ throw_internal };
use Perl::Critic::Utils qw{ :characters :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::ProhibitProlongedStrictureOverride;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::RequireTestLabels;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Hash my %LABEL_ARG_POS => (
ok => 1,
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict;
use 5.006001;
@@ -18,7 +11,7 @@ use Scalar::Util qw{ blessed };
use Perl::Critic::Utils qw{ :severities $EMPTY };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::TestingAndDebugging::RequireUseWarnings;
use 5.006001;
@@ -18,7 +11,7 @@ use version ();
use Perl::Critic::Utils qw{ :severities $EMPTY };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Utils::PPI qw{ is_ppi_statement_subclass };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion;
use 5.006001;
@@ -24,7 +17,7 @@ use Scalar::Util qw{ blessed };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals;
use 5.006001;
@@ -17,7 +10,7 @@ use List::MoreUtils qw(any);
use Perl::Critic::Utils qw{ :characters :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitLongChainsOfMethodCalls;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils::PPI qw{ is_ppi_expression_or_generic_statement };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{ :booleans :characters :severities :data_conversion }
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#----------------------------------------------------------------------------
@@ -170,7 +163,7 @@ sub _determine_allowed_values {
}
if ($all_integers_allowed) {
- @allowed_values = grep { $_ != int $_ } @potential_allowed_values;
+ @allowed_values = grep { $_ != int $_ } @potential_allowed_values; ## no critic ( BuiltinFunctions::ProhibitUselessTopic )
} else {
@allowed_values = @potential_allowed_values;
}
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitMismatchedOperators;
use 5.006001;
use strict;
@@ -14,7 +7,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators;
use 5.006001;
@@ -18,11 +11,11 @@ use base 'Perl::Critic::Policy';
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
Readonly::Hash my %LOW_BOOLEANS => hashify( qw( not or and ) );
-Readonly::Hash my %HIGH_BOOLEANS => hashify( qw( ! || && ) );
+Readonly::Hash my %HIGH_BOOLEANS => hashify( qw( ! || && ||= &&= //=) );
Readonly::Hash my %EXEMPT_TYPES => hashify(
qw(
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitNoisyQuotes;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitVersionStrings;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::RequireConstantVersion;
use 5.006001;
@@ -26,7 +19,7 @@ use Readonly;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -124,24 +117,13 @@ sub violates {
#-----------------------------------------------------------------------------
-# Check for an assignment operator. This is made more complicated by the fact
-# that PPI parses things like '||=' as two PPI::Token::Operators: '||' and
-# '='. So we take the first presumptive operator as an argument. If it is not
-# a PPI::Token::Operator, we return. If it's '=', we return it. If it is any
-# other operator, we see if the next significant token is '=', and if so
-# return that.
+# Check if the element is an assignment operator.
sub _check_for_assignment_operator {
my ( $operator ) = @_;
- return if not $operator->isa( 'PPI::Token::Operator' );
- return $operator if $EQUAL eq $operator->content();
-
- my $next;
- return if not $next = $operator->snext_sibling();
- return if not $next->isa( 'PPI::Token::Operator' );
- return $next if $EQUAL eq $next->content();
-
+ return if not $operator->isa( 'PPI::Token::Operator' );
+ return $operator if is_assignment_operator($operator->content());
return;
}
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars;
use 5.006001;
@@ -20,7 +13,7 @@ use base 'Perl::Critic::Policy';
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::RequireNumberSeparators;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitAugmentedAssignmentInDeclaration;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -45,16 +38,6 @@ sub violates {
my $found = firstval { $_->isa('PPI::Token::Operator') } $elem->children();
if ( $found ) {
my $op = $found->content();
- if ( !exists $augmented_assignments{ $op } ) {
- # PPI doesn't parse all augmented assignment operators. Detect
- # the unsupported ones by concatenating two immediately adjacent
- # operators and trying again.
- my $immediately_adjacent = $found->next_sibling(); # not snext_sibling()
- if ( $immediately_adjacent && $immediately_adjacent->isa('PPI::Token::Operator') ) {
- $op .= $immediately_adjacent->content();
- }
- }
-
if ( exists $augmented_assignments{ $op } ) {
return $self->violation( sprintf( $DESC, $op ), $EXPL, $found );
}
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,9 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
package Perl::Critic::Policy::Variables::ProhibitEvilVariables;
use 5.006001;
@@ -22,7 +16,7 @@ use Perl::Critic::Utils::DataConversion qw{ dor };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitLocalVars;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitMatchVars;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitPackageVars;
use 5.006001;
@@ -21,7 +14,7 @@ use Perl::Critic::Utils qw{
};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -125,7 +118,7 @@ sub _is_vars_pragma {
}
sub _all_upcase { ##no critic(ArgUnpacking)
- return all { $_ eq uc $_ } @_;
+ return all { $_ eq uc $_ } @_; ## no critic ( BuiltinFunctions::ProhibitUselessTopic )
}
1;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitPerl4PackageNames;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :characters :severities :classification };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitPunctuationVars;
use 5.006001;
@@ -21,7 +14,7 @@ use Perl::Critic::Utils qw<
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -301,7 +294,7 @@ sub _create_magic_detector {
. (
join
q<|>,
- map { quotemeta $_ }
+ map { quotemeta }
reverse sort { length $a <=> length $b }
map { _bracketed_form_of_variable_name( $_ ) }
grep { q<%> ne substr $_, 0, 1 }
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitReusedNames;
use 5.006001;
@@ -16,7 +9,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :data_conversion };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -47,22 +40,21 @@ sub violates {
return if 'local' eq $elem->type;
my $allow = $self->{_allow};
- my @names = grep { not $allow->{$_} } $elem->variables();
- my $names = [ @names ];
+ my $names = [ grep { not $allow->{$_} } $elem->variables() ];
# Assert: it is impossible for @$names to be empty in valid Perl syntax
# But if it IS empty, this code should still work but will be inefficient
- # walk up the PDOM looking for declared variables in the same
- # scope or outer scopes quit when we hit the root or when we find
- # violations for all vars (the latter is a shortcut)
+ # Walk up the PDOM looking for declared variables in the same
+ # scope or outer scopes. Quit when we hit the root or when we find
+ # violations for all vars (the latter is a shortcut).
my $outer = $elem;
my @violations;
while (1) {
my $up = $outer->sprevious_sibling;
if (not $up) {
$up = $outer->parent;
+ last if !$up; # top of PDOM, we're done
}
- last if !$up; # top of PDOM, we're done
$outer = $up;
if ($outer->isa('PPI::Statement::Variable') && 'local' ne $outer->type) {
@@ -74,7 +66,7 @@ sub violates {
last if not $names; # found violations for ALL variables, we're done
}
}
- }
+ }
return @violations;
}
@@ -175,7 +167,7 @@ a nice feature.
=head1 COPYRIGHT
-Copyright (c) 2008-2011 Chris Dolan
+Copyright (c) 2008-2013 Chris Dolan
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProhibitUnusedVariables;
use 5.006001;
@@ -19,7 +12,7 @@ use PPI::Token::Symbol;
use Perl::Critic::Utils qw< :characters :severities >;
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::ProtectPrivateVars;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::RequireInitializationForLocalVars;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::RequireLexicalLoopIterators;
use 5.006001;
@@ -16,7 +9,7 @@ use version ();
use Perl::Critic::Utils qw{ :booleans :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities :classification $EMPTY hashify};
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy::Variables::RequireNegativeIndices;
use 5.006001;
@@ -15,7 +8,7 @@ use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Policy;
use 5.006001;
@@ -47,7 +40,7 @@ use Perl::Critic::Violation qw<>;
use Exception::Class; # this must come after "use P::C::Exception::*"
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyConfig;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Readonly;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
use Perl::Critic::Exception::AggregateConfiguration;
use Perl::Critic::Exception::Configuration::Option::Policy::ParameterValue;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyFactory;
use 5.006001;
@@ -36,7 +29,7 @@ use Perl::Critic::Utils::Constants qw{ :profile_strictness };
use Exception::Class; # this must come after "use P::C::Exception::*"
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyListing;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Policy qw();
use overload ( q<""> => 'to_string' );
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior::Boolean;
use 5.006001;
@@ -14,7 +7,7 @@ use Perl::Critic::Utils;
use base qw{ Perl::Critic::PolicyParameter::Behavior };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior::Enumeration;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw{ :characters &words_from_string &hashify };
use base qw{ Perl::Critic::PolicyParameter::Behavior };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior::Integer;
use 5.006001;
@@ -15,7 +8,7 @@ use Perl::Critic::Utils qw{ :characters };
use base qw{ Perl::Critic::PolicyParameter::Behavior };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior::String;
use 5.006001;
@@ -15,7 +8,7 @@ use Perl::Critic::Utils;
use base qw{ Perl::Critic::PolicyParameter::Behavior };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior::StringList;
use 5.006001;
@@ -15,7 +8,7 @@ use Perl::Critic::Utils qw{ :characters &words_from_string &hashify };
use base qw{ Perl::Critic::PolicyParameter::Behavior };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter::Behavior;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Perl::Critic::Utils qw{ :characters };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::PolicyParameter;
use 5.006001;
@@ -30,7 +23,7 @@ use Perl::Critic::PolicyParameter::Behavior::StringList;
use Perl::Critic::Utils qw{ :characters &interpolate };
use Perl::Critic::Utils::DataConversion qw{ &defined_or_empty };
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Scalar our $NO_DESCRIPTION_AVAILABLE => 'No description available.';
@@ -56,6 +56,10 @@ Write C<< eval { $foo->can($name) } >> instead of C<UNIVERSAL::can($foo, $name)>
Write C<< eval { $foo->isa($pkg) } >> instead of C<UNIVERSAL::isa($foo, $pkg)>. [Default severity 3]
+=head2 L<BuiltinFunctions::ProhibitUselessTopic|Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic>
+
+Don't pass $_ to built-in functions that assume it, or to most filetest operators. [Default severity 2]
+
=head2 L<BuiltinFunctions::ProhibitVoidGrep|Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep>
Don't use C<grep> in void contexts. [Default severity 3]
@@ -66,11 +70,11 @@ Don't use C<map> in void contexts. [Default severity 3]
=head2 L<BuiltinFunctions::RequireBlockGrep|Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep>
-Write C<grep { $_ =~ /$pattern/ } @list> instead of C<grep /$pattern/, @list>. [Default severity 4]
+Write C<grep { /$pattern/ } @list> instead of C<grep /$pattern/, @list>. [Default severity 4]
=head2 L<BuiltinFunctions::RequireBlockMap|Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap>
-Write C<map { $_ =~ /$pattern/ } @list> instead of C<map /$pattern/, @list>. [Default severity 4]
+Write C<map { /$pattern/ } @list> instead of C<map /$pattern/, @list>. [Default severity 4]
=head2 L<BuiltinFunctions::RequireGlobFunction|Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction>
@@ -352,6 +356,10 @@ Only use a capturing group if you plan to use the captured value. [Default sever
Use only C<//> or C<{}> to delimit regexps. [Default severity 1]
+=head2 L<RegularExpressions::ProhibitUselessTopic|Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic>
+
+Don't use $_ to match against regexes. [Default severity 2]
+
=head2 L<RegularExpressions::RequireBracesForMultiline|Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline>
Use C<{> and C<}> to delimit multi-line regexps. [Default severity 1]
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::ProfilePrototype;
use 5.006001;
@@ -18,7 +11,7 @@ use Perl::Critic::Policy qw{};
use Perl::Critic::Utils qw{ :characters };
use overload ( q{""} => 'to_string' );
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -168,7 +161,9 @@ sub to_string {
Perl::Critic::Policy::set_format( $self->_proto_format() );
- return $prototype . "\n\n" . join q{}, map { "$_" } @{ $self->_get_policies() };
+ my $policy_prototypes = join qq{\n}, map { "$_" } @{ $self->_get_policies() };
+ $policy_prototypes =~ s/\s+ \z//xms; # Trim trailing whitespace
+ return $prototype . "\n\n" . $policy_prototypes . "\n";
}
#-----------------------------------------------------------------------------
@@ -198,7 +193,6 @@ ${prefix}add_themes =
${prefix}severity = %s
${prefix}maximum_violations_per_document = %v
%{\\n%\\x7b# \\x7df\\n${prefix}%n = %D\\n}O%{${prefix}Cannot programmatically discover what parameters this policy takes.\\n}U
-
END_OF_FORMAT
}
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Statistics;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils::McCabe qw{ calculate_mccabe_of_sub };
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::TestUtils;
use 5.006001;
@@ -29,7 +22,7 @@ use Perl::Critic::Exception::Fatal::Internal qw{ &throw_internal };
use Perl::Critic::Utils qw{ :severities :data_conversion policy_long_name };
use Perl::Critic::PolicyFactory (-test => 1);
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Array our @EXPORT_OK => qw(
pcritique pcritique_with_violations
@@ -142,7 +135,7 @@ sub subtests_in_tree {
find(
{
wanted => sub {
- return if not -f $_;
+ return if not -f;
my ($fileroot) = m{(.+)[.]run\z}xms;
@@ -355,7 +348,7 @@ sub bundled_policy_names {
require ExtUtils::Manifest;
my $manifest = ExtUtils::Manifest::maniread();
my @policy_paths = map {m{\A lib/(Perl/Critic/Policy/.*).pm \z}xms} keys %{$manifest};
- my @policies = map { join q{::}, split m{/}xms, $_} @policy_paths;
+ my @policies = map { join q{::}, split m{/}xms } @policy_paths;
my @sorted_policies = sort @policies;
return @sorted_policies;
}
@@ -368,7 +361,7 @@ sub names_of_policies_willing_to_work {
->new( %configuration )
->policies();
- return map { ref $_ } @policies_willing_to_work;
+ return map { ref } @policies_willing_to_work;
}
1;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Theme;
use 5.006001;
@@ -24,7 +17,7 @@ use Perl::Critic::Exception::Configuration::Option::Global::ParameterValue
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::ThemeListing;
use 5.006001;
@@ -17,7 +10,7 @@ use Perl::Critic::Utils qw< hashify >;
use overload ( q<""> => 'to_string' );
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::UserProfile;
use 5.006001;
@@ -23,7 +16,7 @@ use Perl::Critic::Exception::Fatal::Internal qw{ throw_internal };
use Perl::Critic::Exception::Configuration::Generic qw{ throw_generic };
use Perl::Critic::PolicyConfig;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::Constants;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ $EMPTY hashify };
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::DataConversion;
use 5.006001;
@@ -16,7 +9,7 @@ use Perl::Critic::Utils qw{ :characters :booleans };
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -36,7 +29,7 @@ sub boolean_to_number { ## no critic (RequireArgUnpacking)
sub dor { ## no critic (RequireArgUnpacking)
foreach (@_) {
- defined $_ and return $_;
+ return $_ if defined;
}
return;
}
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::McCabe;
use 5.006001;
@@ -19,7 +12,7 @@ use Exporter 'import';
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::POD::ParseInteriorSequence;
use 5.006001;
@@ -15,7 +8,7 @@ use base qw{ Pod::Parser };
use IO::String;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::POD;
use 5.006001;
@@ -24,7 +17,7 @@ use Perl::Critic::Utils qw< :characters >;
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::PPI;
use 5.006001;
@@ -17,7 +10,7 @@ use Scalar::Util qw< blessed readonly >;
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Utils::Perl;
use 5.006001;
@@ -13,7 +6,7 @@ use warnings;
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# NOTE: This module is way too large. Please think about adding new
# functionality into a P::C::Utils::* module instead.
@@ -27,7 +20,7 @@ use Perl::Critic::Utils::PPI qw< is_ppi_expression_or_generic_statement >;
use Exporter 'import';
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
# Exportable symbols here.
@@ -70,6 +63,7 @@ Readonly::Array our @EXPORT_OK => qw(
first_arg
hashify
interpolate
+ is_assignment_operator
is_class_name
is_function_call
is_hash_key
@@ -146,6 +140,7 @@ Readonly::Hash our %EXPORT_TAGS => (
],
classification => [
qw{
+ is_assignment_operator
is_class_name
is_function_call
is_hash_key
@@ -826,18 +821,17 @@ sub is_subroutine_name {
#-----------------------------------------------------------------------------
sub is_function_call {
- my $elem = shift;
- return if !$elem;
+ my $elem = shift or return;
- return if is_hash_key($elem);
+ return if is_perl_bareword($elem);
+ return if is_perl_filehandle($elem);
+ return if is_package_declaration($elem);
+ return if is_included_module_name($elem);
return if is_method_call($elem);
return if is_class_name($elem);
return if is_subroutine_name($elem);
- return if is_included_module_name($elem);
- return if is_package_declaration($elem);
- return if is_perl_bareword($elem);
- return if is_perl_filehandle($elem);
return if is_label_pointer($elem);
+ return if is_hash_key($elem);
return 1;
}
@@ -1175,6 +1169,16 @@ sub words_from_string {
#-----------------------------------------------------------------------------
+sub is_assignment_operator {
+ my $elem = shift;
+
+ return if $elem !~ m/= \Z/xms;
+ return if $elem =~ m/\A [=<>] = \Z/xms; # Exclude == >= <=
+ return 1;
+}
+
+#-----------------------------------------------------------------------------
+
sub is_unchecked_call {
my $elem = shift;
@@ -1423,6 +1427,11 @@ will not match variables, subroutine names, literal strings, numbers,
or symbols. If the document doesn't contain any matches, returns
undef.
+=item C<is_assignment_operator( $element )>
+
+Given a L<PPI::Token::Operator|PPI::Token::Operator> or a string,
+returns true if that token represents one of the assignment operators
+(e.g. C<= &&= ||= //= += -=> etc.).
=item C<is_perl_global( $element )>
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic::Violation;
use 5.006001;
@@ -29,7 +22,7 @@ use Perl::Critic::Utils::POD qw<
>;
use Perl::Critic::Exception::Fatal::Internal qw< throw_internal >;
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Scalar my $LOCATION_LINE_NUMBER => 0;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Perl::Critic;
use 5.006001;
@@ -29,7 +22,7 @@ use Perl::Critic::Utils qw< :characters hashify shebang_line >;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
Readonly::Array our @EXPORT_OK => qw(critique);
@@ -883,10 +876,14 @@ L<Email::Address|Email::Address>
L<Exception::Class|Exception::Class>
+L<File::HomeDir|File::HomeDir>
+
L<File::Spec|File::Spec>
L<File::Spec::Unix|File::Spec::Unix>
+L<File::Which|File::Which>
+
L<IO::String|IO::String>
L<List::MoreUtils|List::MoreUtils>
@@ -915,19 +912,13 @@ L<String::Format|String::Format>
L<Task::Weaken|Task::Weaken>
+L<Term::ANSIColor|Term::ANSIColor>
+
L<Text::ParseWords|Text::ParseWords>
L<version|version>
-The following modules are optional, but recommended for complete
-functionality:
-
-L<File::HomeDir|File::HomeDir>
-
-L<File::Which|File::Which>
-
-
=head1 CONTACTING THE DEVELOPMENT TEAM
You are encouraged to subscribe to the mailing list; send a message to
@@ -1015,7 +1006,7 @@ Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
=head1 COPYRIGHT
-Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
+Copyright (c) 2005-2013 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
@@ -1,12 +1,3 @@
-#!perl
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
package Test::Perl::Critic::Policy;
use 5.006001;
@@ -29,7 +20,7 @@ use Perl::Critic::TestUtils qw<
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -96,7 +87,7 @@ sub _validate_wanted_policy_names {
my @wanted_policies = @{ $wanted_policies };
- my @invalid = grep {my $p = $_; none {$_ =~ $p} @all_testable_policies} @wanted_policies;
+ my @invalid = grep {my $p = $_; none { $_ =~ $p } @all_testable_policies} @wanted_policies;
croak( q{No tests found for policies matching: } . join q{, }, @invalid ) if @invalid;
return 1;
}
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -21,7 +14,7 @@ use Test::More;
#-----------------------------------------------------------------------------
-our $VERSION = '1.121';
+our $VERSION = '1.122';
#-----------------------------------------------------------------------------
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -285,7 +278,7 @@ my $total_policies = scalar @names_of_policies_willing_to_work;
-exclude => \@exclude,
);
my @policies = Perl::Critic::Config->new( %pc_args )->policies();
- my $matches = grep { my $pol = ref $_; grep { $pol !~ /$_/ixms} @exclude } @policies;
+ my $matches = grep { my $pol = ref; grep { $pol !~ /$_/ixms} @exclude } @policies;
is(scalar @policies, $matches, 'exclude pattern matching');
}
@@ -304,7 +297,7 @@ my $total_policies = scalar @names_of_policies_willing_to_work;
-exclude => \@exclude,
);
my @policies = Perl::Critic::Config->new( %pc_args )->policies();
- my @pol_names = map {ref $_} @policies;
+ my @pol_names = map {ref} @policies;
is_deeply(
[grep {/block/ixms} @pol_names],
[],
@@ -378,7 +371,7 @@ my $total_policies = scalar @names_of_policies_willing_to_work;
my %zero_args = map { $_ => 0 }
# Zero is an invalid Term::ANSIColor value.
- grep { $_ !~ m/ \A-color-severity- /smx } @switches;
+ grep { ! / \A-color-severity- /smx } @switches;
$c = Perl::Critic::Config->new( %zero_args );
is( $c->force(), 0, 'zero -force');
is( $c->only(), 0, 'zero -only');
@@ -1,17 +1,8 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-
# Test that all the problems in an rc file get reported and not just the first
# one that is found.
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/Perl-Critic/t/00_modules.t $
-# $Date: 2009-11-01 20:13:44 -0500 (Sun, 01 Nov 2009) $
-# $Author: clonezone $
-# $Revision: 3699 $
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## There's too much use of source code in strings.
## no critic (RequireInterpolationOfMetachars)
@@ -25,7 +18,7 @@ use Perl::Critic::PolicyFactory;
use Perl::Critic::TestUtils qw(bundled_policy_names);
use Perl::Critic::Utils;
-use Test::More tests => 124;
+use Test::More tests => 141;
#-----------------------------------------------------------------------------
@@ -35,6 +28,7 @@ our $VERSION = '1.121';
test_export();
test_find_keywords();
+test_is_assignment_operator();
test_is_hash_key();
test_is_script();
test_is_script_with_PL_files();
@@ -115,6 +109,22 @@ sub test_find_keywords {
#-----------------------------------------------------------------------------
+sub test_is_assignment_operator {
+
+ for ( qw(||= &&= //= += *= -= >>= <<=) ) {
+ is( is_assignment_operator($_), 1, "$_ is an assignment operator" )
+ }
+
+
+ for ( qw(== =~ >= <= + - * / %) ) {
+ is( !!is_assignment_operator($_), q{}, "$_ is not an assignment operator" )
+ }
+
+ return;
+}
+
+#-----------------------------------------------------------------------------
+
sub test_is_hash_key {
my $code = 'sub foo { return $h1{bar}, $h2->{baz}, $h3->{ nuts() } }';
my $doc = PPI::Document->new(\$code);
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -29,7 +22,7 @@ Perl::Critic::TestUtils::block_perlcriticrc();
my $profile = Perl::Critic::UserProfile->new();
my $factory = Perl::Critic::PolicyFactory->new( -profile => $profile );
-my @found_policies = sort map { ref $_ } $factory->create_all_policies();
+my @found_policies = sort map { ref } $factory->create_all_policies();
my $test_label = 'successfully loaded policies matches MANIFEST';
is_deeply( \@found_policies, [bundled_policy_names()], $test_label );
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
@@ -3,8 +3,3 @@
foo
arglbargl # Some other comment.
bar
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
=for stopwords arglbargl
=cut
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -122,14 +122,6 @@ $bar = grep({foo()} @list) && 1;
$hash->{grep};
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -53,14 +53,6 @@ map {my $a = $foo{$_};$a} @list;
map {my $a = $foo{$_};$a;$b} @list;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -56,13 +56,6 @@ substr( $foo, 0, 0 ) = 'bar';
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -41,13 +41,6 @@ is( pcritique($policy, \$code), 0, $policy );
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -70,13 +70,6 @@ $foo{select};
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -118,13 +118,6 @@ eval("#" . substr($^X, 0, 0));
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -83,13 +83,6 @@ split( @list );
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -17,13 +17,6 @@ UNIVERSAL::can($foo, $funcname);
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -17,13 +17,6 @@ UNIVERSAL::isa($foo, $pkg);
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -0,0 +1,66 @@
+## name Topics in a filetest
+## failures 2
+## cut
+
+my $x = -s $_;
+if ( -f $_ ) { foo(); }
+
+#-----------------------------------------------------------------------------
+
+## name Topics in a filetest: -t $_ is not useless because -t defaults to STDIN
+## failures 0
+## cut
+
+if ( -t $_ ) { foo(); }
+
+#-----------------------------------------------------------------------------
+
+## name Topics in a function call, with parens
+## failures 5
+## cut
+
+my $x = length($_);
+my $y = sin($_);
+my $z = defined($_);
+my @x = split( /\t/, $_ );
+unlink($_);
+# Policy cannot handle this yet.
+#my $backwards = reverse($_);
+
+#-----------------------------------------------------------------------------
+
+## name Topics in a function call, no parens
+## failures 6
+## cut
+
+my $x = length $_;
+my $y = sin $_;
+my $z = defined $_;
+my @x = split /\t/, $_;
+unlink $_;
+my $backwards = reverse $_;
+
+#-----------------------------------------------------------------------------
+
+## name Function calls with $_ but in ways that should not be flagged.
+## failures 0
+## cut
+
+my @y = split( /\t/, $_, 3 );
+my @y = split /\t/, $_, 3;
+unlink $_ . '.txt';
+my $z = sin( $_ * 4 );
+my $a = tan $_ + 5;
+# The following two should NOT be flagged as errors. See KNOWN BUGS in the module.
+#my @backwards = reverse $_;
+#my @backwards = reverse($_);
+
+#-----------------------------------------------------------------------------
+# Local Variables:
+# mode: cperl
+# cperl-indent-level: 4
+# fill-column: 78
+# indent-tabs-mode: nil
+# c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
@@ -61,13 +61,6 @@ delete @hash{ grep ( m/ foo /smx, keys %hash ) };
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -60,13 +60,6 @@ delete @hash{ map ( uc( $_ ), keys %hash ) };
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -31,13 +31,6 @@ $hash1{grep} = 1;
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -31,13 +31,6 @@ $hash1{map} = 1;
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -34,13 +34,6 @@ while (<$fh>) {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -42,13 +42,6 @@ sort { -M $b <=> -M $a} @entries;
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -27,13 +27,6 @@ sub AUTOLOAD {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -17,13 +17,6 @@ push @ISA, 'Foo';
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -27,13 +27,6 @@ my $self = bless( [] );
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -143,13 +143,6 @@ state ( $foo );
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -94,13 +94,6 @@ use Foo ('foo', 'bar', '1/2');
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -105,13 +105,6 @@ $median = ( $times[ int $array_size / 2 ] +
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -28,13 +28,6 @@ for($i=0; $i<=$max; $i++){
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -74,13 +74,6 @@ else {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -122,13 +122,6 @@ if ($condition) {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -34,13 +34,6 @@ UNITCHECK : { $x = 1; }
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -198,13 +198,6 @@
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -47,13 +47,6 @@ print {$test_file} <<'END_FOOTER';
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -306,14 +299,6 @@ END_COMPARATOR_CODE
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -211,13 +211,6 @@ Exception::Class->throw($arg1, $arg2) unless not $error;
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -20,13 +20,6 @@ unless($condition){
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name Basic passing
## failures 0
## cut
@@ -20,13 +20,6 @@ until($condition){
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -245,13 +245,6 @@ Blah...
=cut
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -112,15 +112,6 @@ Mutli-paragrapm comment
=cut
__END__
-
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -142,13 +142,6 @@ See L<C<perldiag>|perldiag> for the gory details.
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -171,13 +171,6 @@ Fubar
=cut
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -408,13 +408,6 @@ my $foo = sub {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -399,12 +399,14 @@ grep { $_ } map { eval $_ } @foo; # Should this be rejected?
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
+## name ||= eval{} (https://github.com/adamkennedy/PPI/issues/74)
+## failures 0
+## cut
+
+$foo ||= eval { something };
+$foo &&= eval { something };
+
+#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
@@ -74,13 +74,6 @@ qx/date/;
if ( $blah ) { `date` }
if ( $blah ) { qx/date/ }
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -38,13 +38,6 @@ $foo{open}; # not a function call
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -15,13 +15,6 @@ if (-t) { }
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -46,13 +46,6 @@ sub select { }
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -21,13 +21,6 @@ while( <> ){}
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -103,13 +103,6 @@ open my $a, 'testing' or die 'error: ', $!;
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -228,13 +228,6 @@ say( { $fh } "foo" );
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name open .. close
## failures 0
## cut
@@ -168,15 +168,6 @@ use autodie;
}
#-----------------------------------------------------------------------------
-
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -169,14 +169,6 @@ use autodie;
open $filehandle;
}
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -385,14 +385,6 @@ foo();
say 'The sun is a mass of incandessent gas';
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -146,14 +146,6 @@ binmode FH, ':encoding(utf8)' or die;
$foo{open}; # not a function call
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/Perl-Critic/t/InputOutput/ProhibitTwoArgOpen.run $
-# $Date: 2009-08-08 19:35:01 -0400 (Sat, 08 Aug 2009) $
-# $Author: clonezone $
-# $Revision: 3504 $
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -31,14 +31,6 @@ $hash{format} = 'foo';
$object->format();
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -27,14 +27,6 @@ $hash{tie} = 'foo';
$object->tie();
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -80,14 +80,6 @@ sub fornicate { ## no critic qw(shizzle)
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -80,13 +80,6 @@ use vars qw(%EXPORT_TAGS);
print 123; # no exporting at all; for test coverage
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -895,14 +895,6 @@ use Foo::Bar;
} if ($a == 1);
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -4,8 +4,3 @@ Fatal Found use of Fatal. Use autodie instead.
# Extra leading and trailing whitespace here is intentional.
Getopt::Std Found use of Getopt::Std. Use Getopt::Long instead.
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -5,8 +5,3 @@
# Extra leading and trailing whitespace here is intentional.
/Getopt::Std/ Found use of Getopt::Std. Use Getopt::Long instead.
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -134,13 +134,6 @@ use Fatal qw< open close >;
use Getopt::Std;
#-----------------------------------------------------------------------------
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-
-##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,12 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-#-----------------------------------------------------------------------------
-
## name param-based failure
## failures 0
## parms { max_mccabe => 100 }
@@ -23,15 +23,6 @@ $some_code = undef;
package foo;
$some_code = undef;
-#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -35,14 +35,6 @@ no MyModule;
use strict;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -117,14 +117,6 @@ DESTROY { warn 'DEAD'; }
1;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -119,14 +119,6 @@ use utf8;
package Foo::Bar;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -310,14 +310,6 @@ package Baz;
1;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -214,14 +214,6 @@ use English qw< blah blah blah >;
use English qw(-no_mactch_vars);
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,11 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-
## name No code
## failures 1
## cut
@@ -1,12 +1,5 @@
#!/usr/bin/env perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -834,14 +827,6 @@ our $G_foo_bar;
our @THING;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -100,14 +100,6 @@ my $left;
my $close;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -54,14 +54,6 @@ create $foo;
create {$foo};
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -36,14 +36,6 @@ $some_ref = \&code;
$value = $one*$two;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -323,13 +323,6 @@ given ( 'abc' ) {
}
}
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name non-captures
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -0,0 +1,115 @@
+## name Non-topic explicitness
+## failures 0
+## cut
+
+my $foo = 'Whatever';
+
+$foo =~ /foo/;
+$foo =~ m/foo/;
+$foo =~ s/foo/bar/;
+$foo =~ tr/a-mn-z/n-za-m/;
+
+#-----------------------------------------------------------------------------
+
+## name Topical exclusion
+## failures 0
+## cut
+
+/foo/;
+m/foo/;
+s/foo/bar/;
+tr/a-mn-z/n-za-m/;
+
+#-----------------------------------------------------------------------------
+
+## name Useless topic
+## failures 10
+## cut
+
+$_ =~ /foo/;
+$_ =~ m/foo/;
+$_ =~ s/foo/bar/;
+$_ =~ tr/a-mn-z/n-za-m/;
+$_ =~ y/a-mn-z/n-za-m/;
+
+# Plus some without spacing
+
+$_=~/foo/;
+$_=~m/foo/;
+$_=~s/foo/bar/;
+$_=~tr/a-mn-z/n-za-m/;
+$_=~y/a-mn-z/n-za-m/;
+
+#-----------------------------------------------------------------------------
+
+## name Useless topic in a negative match
+## failures 5
+## cut
+
+$_ !~ /foo/;
+$_ !~ m/foo/;
+$_ !~ s/foo/bar/;
+$_ !~ tr/a-mn-z/n-za-m/;
+$_ !~ y/a-mn-z/n-za-m/;
+
+#-----------------------------------------------------------------------------
+
+## name Match against qr object
+## failures 2
+## cut
+
+$_ =~ qr/bar/;
+$_ !~ qr/bar/;
+
+#-----------------------------------------------------------------------------
+
+## name Not useless matching against a variable
+## failures 0
+## cut
+
+my $non_useless_topic_regex = qr/foo.+bar/;
+$_ =~ $non_useless_topic_regex;
+
+#-----------------------------------------------------------------------------
+
+## name More complex constructions
+## failures 8
+## cut
+
+my $x = scalar( grep { $_ =~ m/^INFO: .*$/ } @foo );
+$x = 3 if $_ !~ s/foo/bar/;
+$_ =~ s/\s+$// foreach ($name, $zip, $phone);
+our @paths = grep { $_ =~ /./ } <DATA>; # get non-blank lines from the end
+next if $_ =~ m/^\s*#/;
+$condition_count += ($_ =~ tr/,/,/) foreach values %requirements;
+my ( $v ) = grep { $_ =~ /^\s*our\s+\$VERSION\s*=\s*['"]\d/ } <$fh>;
+assert( ! grep { $_ =~ m/\|/ } @$suggestions, 'no suggestion contains a pipe character (reserved for future field separator)' );
+
+#-----------------------------------------------------------------------------
+
+## name Potential false positives, but none should fail.
+## failures 0
+## cut
+
+$x =~ /foo/;
+$_ += /foo/;
+print s/x/y/;
+foo(tr/x/y/);
++tr/x/y/;
+# $_ =~ /foo/
+'foo' =~ $_;
+$_ =~ $some_qr_var;
+ok( ( grep { $_ =~ $regwarn } ( $title->warnings() ) ), 'expected warning text reported' );
+my ( $line, $dummy ) = grep { $_ =~ $stat->{regex} } @contents;
+if ($_ !~ $pat) { foo(); }
+=head1 $_ =~ /foo/
+
+#-----------------------------------------------------------------------------
+# Local Variables:
+# mode: cperl
+# cperl-indent-level: 4
+# fill-column: 78
+# indent-tabs-mode: nil
+# c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name short match regexps
## failures 0
## cut
@@ -110,13 +110,6 @@ use re qw{ /smx };
my $string =~ m{pattern.};
}
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -65,14 +65,6 @@ goto &foo;
sort &foo($x)
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -35,14 +35,6 @@ CHECK { do_something(); }
END { do_something(); }
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -48,14 +48,6 @@ sub test_sub {
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -38,14 +38,6 @@ $foo{return}; # hash key, not keyword
sub foo {return}; # no sibling
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
## name basic passes
## failures 0
## cut
@@ -55,14 +55,6 @@ sub quack {
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -55,14 +55,6 @@ $foo{sort}; # hash key, not keyword
sub foo {return}; # no sibling
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -15,14 +15,6 @@ sub my_sub1 {}
sub my_sub1 {}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -234,15 +234,6 @@ sub _second {
}
#-----------------------------------------------------------------------------
-
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -159,15 +159,6 @@ Other::Package->_bar;
$self->Other::Package::_baz();
#-----------------------------------------------------------------------------
-
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -423,13 +423,16 @@ sub foo {
#-----------------------------------------------------------------------------
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
+## name MOOSE idiom (https://github.com/adamkennedy/PPI/issues/74)
+## failures 0
+## cut
+sub BUILD {
+ my ($class, $options_ref) = @_;
+ $options_ref ||= @_;
+}
+
+#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,13 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-
-#-----------------------------------------------------------------------------
-
## name basic passes
## failures 0
## cut
@@ -96,14 +96,6 @@ package foo;
no strict "refs", 'vars', "subs";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -126,14 +126,6 @@ no warnings 'qw'; # Yes, 'qw' is an actual warnings category.
no warnings ( foo => "bar" );
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -79,14 +79,6 @@ sub foo {
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -94,14 +94,6 @@ is_deeply( { foo => 1 }, { foo => 1 }, 'Boldly criticize where nobody has critic
is_deeply( { get_empty_array() }, {}, 'Wrap sub-call in hash constructor' );
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -202,13 +202,6 @@ $foo = $bar;
sub foo { use 5.011 };
$this_is_not_strict
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -216,14 +216,6 @@ $this_is_not_covered_by_warnings;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -292,14 +292,6 @@ sub new {
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -206,13 +206,6 @@ use SomeOtherModule; our $VERSION = $SomeOtherModule::VERSION;
use SomeOtherModule; our $VERSION = SomeOtherModule::VERSION;
use base 'SomeOtherModule'; our $VERSION = $SomeOtherModule::VERSION;
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -16,14 +16,6 @@ use constant FOO => 42;
use constant BAR => 24;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -34,14 +34,6 @@ $var = 'the';
$var = "other";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -19,14 +19,6 @@ q{\x7f};
qq{\x7F\x06\x22Z};
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -47,14 +47,6 @@ $x = qq
<1>;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -114,14 +114,6 @@ $text = "Anyone \\\@home?";
$text = "Here we do not have\\\\ta tab";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -150,14 +150,6 @@ umask 002;
umask ( 002 );
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -72,14 +72,6 @@ $blargh = $x->[1]->{z}->[3]->{u};
$c->response->content_type( 'text/html; charset=utf-8' )
unless $c->response->content_type;
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -982,14 +982,6 @@ package 42; # Illegal, but check anyway.
package Maggot 0.01 42;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -115,14 +115,6 @@ $a .= 1;
-A 'file' eq "1";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,11 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-
## name High-precedence passing
## failures 0
## cut
@@ -65,6 +57,15 @@ eval {
}
};
+#-----------------------------------------------------------------------------
+
+## name Mixed booleans with ||= and &&= operators (https://github.com/adamkennedy/PPI/issues/74)
+## failures 2
+## cut
+
+$foo ||= $this or $that;
+$foo &&= $this or $that;
+
##############################################################################
# Local Variables:
# mode: cperl
@@ -67,14 +67,6 @@ $var = "{[";
$var = "]}";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -163,14 +163,6 @@ $x =~ s```;
$x =~ tr```;
$x =~ y```;
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -60,14 +60,6 @@ I will attempt to remedy the situation by running sh for you...
__end__
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -55,14 +55,6 @@ use Foo::Bar
plugh => 1;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -285,14 +285,6 @@ our $VERSION = version->new(qw$Revision$);
sprintf( q{%s/%s}, __PACKAGE__, $VERSION ) =~ s{ o \z }{}xms;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -306,14 +306,6 @@ send_email_to('$some_var: foo@bar.com', ...);
'\y';
'\z';
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -77,14 +77,6 @@ $var = -1000_000.01;
$var = -10000_000.01;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -47,14 +47,6 @@ The only thing we have to fear is fear itself...
END_QUOTE
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -36,14 +36,6 @@ print << 'END_QUOTE';
The only thing we have to fear is fear itself...
END_QUOTE
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -118,14 +118,6 @@ my $port ||= $port_memoized || $ENV{APACHE_TEST_PORT} || $self->{vars}{port} ||
my $output .= '<?' . $_[0]->getNodeName;
my $data .= &stripzerobytes(inet_aton($self->address()));
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -89,13 +89,6 @@ local ($foo) = $bar until $baz;
local ($foo, $bar) = 1 foreach @baz;
local ($foo, $bar) = 1 for @baz;
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -5,8 +5,3 @@ $SIG{__DIE__} Found use of $SIG{__DIE__}. Use END{} or override CORE::GLOBAL::di
# Extra leading and trailing whitespace here is intentional.
$^S Found use of $^S. You should seriously consider what your code is trying to do.
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -5,8 +5,3 @@
# Extra leading and trailing whitespace here is intentional.
/\$\^S/ Found use of $^S. You should seriously consider what your code is trying to do.
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -155,13 +155,6 @@ local $SIG{__DIE__} = sub {warn "I cannot die!"};
print $^S ? 'Executing eval' : defined $^S ? 'Otherwise' : 'Parsing';
#-----------------------------------------------------------------------------
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-
-##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -28,14 +28,6 @@ local $SIG{HUP} \&handler;
local $INC{$module} = $path;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -28,14 +28,6 @@ use English qw(-no_match_vars);
use English qw($EVAL_ERROR);
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -137,14 +137,6 @@ $Override::Defaults::tango = 47;
$::foo = 1;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -241,14 +241,6 @@ $foo = \&';
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -420,14 +420,6 @@ qr/foo$/
"${$}";
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -281,14 +281,6 @@ package Bar;
our @ISA;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -161,14 +161,6 @@ my %foo;
m/ (?{ $foo{bar} }) /smx;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -23,14 +23,6 @@ $_foo;
$::_foo;
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -35,14 +35,6 @@ our ($foo, $bar);
$x->{local};
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -68,14 +68,6 @@ foreach $foo ( @list ) {
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,10 +1,4 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
use 5.006001;
use strict;
@@ -342,14 +336,6 @@ for my $entry (
}
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -61,14 +61,6 @@ $some->{complicated}->[$data_structure]->[$#{$ref} -1];
$ref->[$#{$some->{complicated}->[$data_structure]} -1];
#-----------------------------------------------------------------------------
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Self-compliance tests
use strict;
@@ -23,8 +16,7 @@ use Perl::Critic::TestUtils qw{ starting_points_including_examples };
# -extra-test-policies option to work.
use Perl::Critic::PolicyFactory (
'-test' => 1,
- '-extra-test-policies' => [ qw{ ErrorHandling::RequireUseOfExceptions
- Miscellanea::RequireRcsKeywords } ],
+ '-extra-test-policies' => [ qw{ ErrorHandling::RequireUseOfExceptions } ],
);
use Test::More;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
profile-strictness = fatal
severity = 1
theme = core
@@ -37,9 +30,6 @@ lines = 20
[InputOutput::RequireCheckedSyscalls]
functions = open close
-[Miscellanea::RequireRcsKeywords]
-keywords = URL Date Author Revision
-
[RegularExpressions::ProhibitUnusualDelimiters]
allow_all_brackets = 1
@@ -115,8 +115,3 @@ unvalidated
vice-versa
whitespace
Wyant
-
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Extra self-compliance tests for Policy classes. This just checks for
# additional POD sections that we want in every Policy module. See the
# 41_perlcriticrc-policies file for the precise configuration.
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
profile-strictness = fatal
severity = 1
only = 1
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Self-compliance tests
use strict;
@@ -23,8 +16,7 @@ use Perl::Critic::TestUtils qw{ starting_points_including_examples };
# -extra-test-policies option to work.
use Perl::Critic::PolicyFactory (
'-test' => 1,
- '-extra-test-policies' => [ qw{ ErrorHandling::RequireUseOfExceptions
- Miscellanea::RequireRcsKeywords } ],
+ '-extra-test-policies' => [ qw{ ErrorHandling::RequireUseOfExceptions } ],
);
use Test::More;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
profile-strictness = fatal
severity = 1
theme = core
@@ -42,9 +35,6 @@ lines = 20
[InputOutput::RequireCheckedSyscalls]
functions = open close
-[Miscellanea::RequireRcsKeywords]
-keywords = URL Date Author Revision
-
# Character length is not a proper measure of complexity.
[-RegularExpressions::ProhibitComplexRegexes]
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
# Simple self-compliance tests for .run files.
use strict;
@@ -1,10 +1,3 @@
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
profile-strictness = fatal
severity = 1
only = 1
@@ -18,6 +11,3 @@ allow_leading_tabs = 0
[CodeLayout::ProhibitTrailingWhitespace]
[Editor::RequireEmacsFileVariables]
-
-[Miscellanea::RequireRcsKeywords]
-keywords = URL Date Author Revision
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!/usr/bin/perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use strict;
use warnings;
@@ -1,50 +0,0 @@
-#!/usr/bin/perl
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-use 5.006001;
-use strict;
-use warnings;
-
-use Readonly; # So we don't barf when we hit Readonly::XS below.
-
-use lib 'inc';
-use Perl::Critic::BuildUtilities qw< recommended_module_versions >;
-
-use Test::More;
-
-#-----------------------------------------------------------------------------
-
-our $VERSION = '1.116';
-
-#-----------------------------------------------------------------------------
-
-# Certain developers change perl installations on occasion and don't always
-# have all the optional modules installed. Make sure that they know that they
-# don't. :]
-
-my %module_versions = (
- recommended_module_versions(),
- 'Test::Memory::Cycle' => 0,
- 'Test::Without::Module' => 0,
-);
-
-plan tests => scalar keys %module_versions;
-
-foreach my $module (sort keys %module_versions) {
- use_ok( $module, $module_versions{$module} );
-}
-
-# Local Variables:
-# mode: cperl
-# cperl-indent-level: 4
-# fill-column: 78
-# indent-tabs-mode: nil
-# c-indentation-style: bsd
-# End:
-# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
@@ -1,11 +1,4 @@
-#!perl -w
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
+#!perl
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!/usr/bin/perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,12 +1,5 @@
#!perl
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
use 5.006001;
use strict;
use warnings;
@@ -1,144 +0,0 @@
-#!/usr/bin/env perl
-
-##############################################################################
-# $URL$
-# $Date$
-# $Author$
-# $Revision$
-##############################################################################
-
-use 5.006001;
-use strict;
-use warnings;
-
-use English qw{-no_match_vars};
-use Readonly;
-use Carp qw{ confess };
-use Fatal qw{ open close };
-
-use lib 'inc';
-
-use Perl::Critic::BuildUtilities qw{ recommended_module_versions };
-
-#-----------------------------------------------------------------------------
-
-our $VERSION = '1.116';
-
-#-----------------------------------------------------------------------------
-
-Readonly::Scalar my $GENERATED_DIRECTORY => 'xt/author/generated/';
-
-if ( not -d $GENERATED_DIRECTORY ) {
- print
- "\n\nSkipping generating tests because it doesn't ",
- "look like we're in an author environment.\n\n";
- exit 0;
-}
-
-print "\n\nGenerating tests that hide modules and then run other tests.\n";
-
-my $this_program = __FILE__;
-
-my @modules_to_hide = sort keys %{ { recommended_module_versions } };
-my $modules_to_hide = join "\n" . q< > x 4, @modules_to_hide;
-
-foreach my $test_program_name (@ARGV) {
- my ($wrapped_test_name) =
- $test_program_name =~ m<
- \A
- $GENERATED_DIRECTORY
- ( (?: t | xt/author ) / [\w.]+ [.] t ) # test to be wrapped
- _without_optional_dependencies [.] t # suffix the new test will have
- \z
- >xmso;
- if (not $wrapped_test_name) {
- confess
- 'Could not figure out the name of the test to wrap from "'
- . $test_program_name
- . q{".};
- }
-
- print "Generating $test_program_name.\n";
- open my $test_program, '>', $test_program_name ## no critic (RequireBriefOpen)
- or confess "Could not open $test_program_name: $ERRNO";
-
- print {$test_program} <<"END_TEST_PROGRAM";
-#!/usr/bin/env perl
-
-# Do not edit!!! This program generated by $this_program.
-
-use strict;
-use warnings;
-
-use English qw{-no_match_vars};
-
-our \$VERSION = $VERSION;
-
-#-----------------------------------------------------------------------------
-
-use Test::Without::Module qw<
- $modules_to_hide
->;
-
-
-require '$wrapped_test_name';
-END_TEST_PROGRAM
-
- close $test_program;
-}
-
-print "Done.\n\n";
-
-__END__
-
-#-----------------------------------------------------------------------------
-
-=pod
-
-=for stopwords
-
-=head1 NAME
-
-generate_without_additional_dependencies_wrappers.PL - generate tests that are wrappers around other tests but which hide the existence of modules first.
-
-
-=head1 SYNOPSIS
-
- generate_without_additional_dependencies_wrappers.PL \
- t/00_modules.t_without_optional_dependencies.t \
- t/01_config.t_without_optional_dependencies.t \
- t/13_bundled_policies.t_without_optional_dependencies.t
-
-
-=head1 DESCRIPTION
-
-Release 1.07 of Perl::Critic was an embarrassment because there were no tests
-of core without the presence of optional modules. This program generates
-wrappers for other tests that hide those optional modules.
-
-
-=head1 AUTHOR
-
-Elliot Shank C<< <perl@galumph.org> >>
-
-
-=head1 COPYRIGHT
-
-Copyright (c) 2007-2009 Elliot Shank.
-
-This program is free software; you can redistribute it and/or modify it under
-the same terms as Perl itself. The full text of this license can be found in
-the LICENSE file included with this module.
-
-
-=cut
-
-##############################################################################
-# Local Variables:
-# mode: cperl
-# cperl-indent-level: 4
-# fill-column: 78
-# indent-tabs-mode: nil
-# c-indentation-style: bsd
-# End:
-# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :