Elliot Shank > Perl-Critic-1.080 > Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions

Download:
Perl-Critic-1.080.tar.gz

Dependencies

Annotate this POD

CPAN RT

New  23
Open  64
Stalled  2
View Bugs
Report a bug
Module Version: 1.080   Source   Latest Release: Perl-Critic-1.105

NAME ^

Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions

DESCRIPTION ^

  until ($foo ne 'blah') {          #not ok
      ...
  }

  while ($foo eq 'blah') {          #ok
      ...
  }

A number of people have problems figuring out the meaning of doubly negated expressions. unless and until are both negative constructs, so any negative (e.g. !~) or reversible operators (e.g. le) included in their conditional expressions are double negations. Conway considers the following operators to be difficult to understand within unless and until:

  ! not
  !~ ne !=
  <   >   <=  >=  <=>
  lt  gt  le  ge  cmp

SEE ALSO ^

Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks

AUTHOR ^

Elliot Shank <perl@galumph.com>

COPYRIGHT ^

Copyright (c) 2007 Elliot Shank. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.