Perl::Critic::Policy::Modules::ProhibitAutomaticExportation - Export symbols via
%EXPORT_TAGS instead of
This Policy is part of the core Perl::Critic distribution.
When using Exporter,
symbols placed in the
@EXPORT variable are automatically exported into the caller's namespace.
this practice is not polite,
and may cause serious problems if the caller declares the same symbols.
The best practice is to place your symbols in
%EXPORT_TAGS and let the caller choose exactly which symbols to export.
package Foo; use Exporter 'import'; our @EXPORT = qw(foo $bar @baz); # not ok our @EXPORT_OK = qw(foo $bar @baz); # ok our %EXPORT_TAGS = ( all => [ qw(foo $bar @baz) ] ); # ok
This Policy is not configurable except for the standard options.
Jeffrey Ryan Thalhammer <firstname.lastname@example.org>
Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.